Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-only] add storage architecture overview #1920

Merged
merged 13 commits into from
Apr 30, 2021
Merged

[docs-only] add storage architecture overview #1920

merged 13 commits into from
Apr 30, 2021

Conversation

butonic
Copy link
Member

@butonic butonic commented Apr 14, 2021

This PR adds documentation to the storage service, with an overview diagram as well as terminology, trying to clarify how ocis / reva works.

butonic added 2 commits April 13, 2021 10:15
@butonic
move ports to dedicated file
095f596 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
add storage architecture overview
01160c3 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@update-docs
Copy link

update-docs bot commented Apr 14, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

pascalwengerter
pascalwengerter previously requested changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work, just cought some typos and added some questions 🤘🏽

@butonic
Apply suggestions from code review
10ac494 
Co-authored-by: Pascal Wengerter <pwengerter@owncloud.com>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the document-architecture branch from 3f3d75d to 10ac494 Compare April 15, 2021 07:56
@butonic butonic requested a review from pascalwengerter April 15, 2021 08:31
pascalwengerter
pascalwengerter reviewed Apr 15, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, excited for @dragotin's suggested changes!

dragotin
dragotin suggested changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@dragotin dragotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some random thoughts that @butonic and me collected in discussions, for reference.

I guess this needs further refinement, we're not yet done ;-)

@butonic
add frontend endpoint descriptions
781272e 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic requested a review from dragotin April 27, 2021 15:16
@butonic
Copy link
Member Author

butonic commented Apr 27, 2021

@dragotin @pascalwengerter I split up and simplfied some of the sections. I'd vote to get this in now and polish iteratively.

butonic added 2 commits April 27, 2021 15:17
@butonic
split up files
b64c224 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
small polish
f7aa238 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the document-architecture branch from 9692e78 to 205b3a7 Compare April 28, 2021 14:45
butonic added 4 commits April 28, 2021 14:45
@butonic
migration sideeffects
205b3a7 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
further migration and namespace thoughts
10d19e5 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
add logical uuids
ec3c649 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
add notes about /home and /home/shares
dcea5cd 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@micbar micbar requested a review from pascalwengerter April 29, 2021 15:21
butonic added 3 commits April 29, 2021 18:08
@butonic
Merge branch 'master' into document-architecture
e4ba643
@butonic
typo
73232b5 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
clarify url types
6dfa4b2 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
dragotin
dragotin approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@dragotin dragotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for the sake of progress :-)

@butonic butonic dismissed pascalwengerter’s stale review April 30, 2021 15:18

already incorporated

@butonic butonic merged commit 6826e57 into master Apr 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the document-architecture branch April 30, 2021 15:19
ownclouders pushed a commit that referenced this pull request Apr 30, 2021
@butonic
commit 6826e57
167f947 
Merge: 46c60cc 6dfa4b2
Author: Jörn Friedrich Dreyer <jfd@butonic.de>
Date:   Fri Apr 30 17:18:56 2021 +0200

    Merge pull request #1920 from owncloud/document-architecture

    [docs-only] add storage architecture overview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragotin dragotin dragotin approved these changes

@micbar micbar micbar approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@butonic @dragotin @micbar @pascalwengerter