Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update reva to v1.6.1-0.20210218130854-a954e7242e7a #1684

Merged
merged 1 commit into from
Feb 23, 2021
Merged

update reva to v1.6.1-0.20210218130854-a954e7242e7a #1684

merged 1 commit into from
Feb 23, 2021

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Feb 19, 2021

Update reva. This includes:

@C0rby C0rby requested review from butonic and refs February 19, 2021 09:52
@C0rby C0rby self-assigned this Feb 19, 2021
@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/3579/73/7
ebUISharingFolderAdvancedPermissionMultipleUsers/sharedFolderWithMultipleUsersAdvancedPermissions.feature:59 failed - that is an annoying intermittent failure, issue #1492 - I restarted CI.

@C0rby
Copy link
Contributor Author

C0rby commented Feb 19, 2021

The windows binary build fails because we are using syscall.Statfs_t{} in some places which is not available in windows.

https://github.com/cs3org/reva/blob/a954e7242e7a7068e6951601d3826d93b0e043c1/pkg/storage/utils/localfs/localfs.go#L525
https://github.com/cs3org/reva/blob/a954e7242e7a7068e6951601d3826d93b0e043c1/pkg/storage/fs/ocis/ocis.go#L222

This needs to be fixed in reva. Something for next week...

@C0rby
Copy link
Contributor Author

C0rby commented Feb 19, 2021

For windows we could to it like this: https://stackoverflow.com/a/60724929

@C0rby C0rby mentioned this pull request Feb 22, 2021
Merged
@C0rby C0rby force-pushed the update-reva branch 3 times, most recently from d4b39ff to ab58458 Compare February 23, 2021 10:27
update reva to v1.6.1-0.20210223065028-53f39499762e
3a46bd2 
Update reva and also set a replace for github.com/oleiade/reflections.
The replace should resolve the dependabot issue. See oleiade/reflections#14. Once https://github.com/ory/fosite has updated to reflections 1.0.1 or higher we can remove the replace.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

wkloucek
wkloucek approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@C0rby C0rby merged commit 1ed2793 into master Feb 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-reva branch February 23, 2021 13:26
ownclouders pushed a commit that referenced this pull request Feb 23, 2021
@C0rby
commit 1ed2793
8947021 
Merge: 52ebb7c 3a46bd2
Author: David Christofas <C0rby@users.noreply.github.com>
Date:   Tue Feb 23 14:26:42 2021 +0100

    Merge pull request #1684 from owncloud/update-reva

    update reva to v1.6.1-0.20210218130854-a954e7242e7a
@exalate-issue-sync exalate-issue-sync bot mentioned this pull request Mar 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek wkloucek approved these changes

@butonic butonic Awaiting requested review from butonic

@refs refs Awaiting requested review from refs

Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@C0rby @phil-davis @wkloucek