Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add php 7.2 #108

Merged
merged 1 commit into from
Dec 20, 2017
Merged

Add php 7.2 #108

merged 1 commit into from
Dec 20, 2017

Conversation

DeepDiver1975
Copy link
Member

No description provided.

@DeepDiver1975 DeepDiver1975 self-assigned this Dec 19, 2017
@codecov
Copy link

codecov bot commented Dec 19, 2017 •
edited
Loading

Codecov Report

Merging #108 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #108      +/-   ##
============================================
+ Coverage      81.4%   81.45%   +0.05%     
  Complexity      185      185              
============================================
  Files            20       20              
  Lines           656      658       +2     
============================================
+ Hits            534      536       +2     
  Misses          122      122
Impacted Files Coverage Δ Complexity Δ
lib/Controller/OAuthApiController.php 100% <0%> (ø) 18% <0%> (ø) ⬇️
lib/Controller/PageController.php 56.03% <0%> (+0.38%) 34% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bb78a0...b4cc4be. Read the comment docs.

PVince81
PVince81 approved these changes Dec 20, 2017
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DeepDiver1975 DeepDiver1975 merged commit c0853a7 into master Dec 20, 2017
@DeepDiver1975 DeepDiver1975 deleted the DeepDiver1975-patch-1 branch December 20, 2017 10:04
@davitol davitol mentioned this pull request Mar 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

Assignees

@DeepDiver1975 DeepDiver1975

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DeepDiver1975 @PVince81