Fixed XML validation error with C# like clients like MusicBee

[rstefko]

No description provided.

[paulijar]

Thanks for the PR. However, I would suggest a small modification: This now adds the xmlns property also in case the API response is requested in JSON format. This makes little sense and is not how the "real" Subsonic server works; this can be observed with the Subsonic demo server by requesting e.g. http://demo.subsonic.org/rest/getIndexes.view?u=guest4&c=Test&f=json&v=1.13.0&p=guest.

So the correct place to add the xmlns attribute would be above this line:

music/lib/Controller/SubsonicController.php

Line 1621 in 5dd2025

$response = new XmlResponse($responseData, $useAttributes);

There, it should be of course written like this: $responseData['subsonic-response']['xmlns'] = 'http://subsonic.org/restapi';.

Furthermore, the attribute xmlns should be added to this array:

music/lib/Controller/SubsonicController.php

Line 1619 in 5dd2025

$useAttributes = \array_merge($useAttributes, ['status', 'version']);

This ensures that the xmlns is always treated as an attribute, even on those few responses where the other key-value pairs are treated as child elements.

[scrutinizer-notifier]

The inspection completed: No new issues

[paulijar]

Great, thanks. I rebased and merged this manually, so I'm just going to close this PR.

Btw, does the connection between MusicBee and ownCloud Music work properly for you after this change? Because for me, this change does help me to get a bit further than before, but then the MusicBee Subsonic plugin gets stuck in the phase "Running GetMusicFolders". I wonder if there is also some other problem in our Subsonic API implementation or if there is just some property in my library specifically which reveals an issue on MusicBee.

[rstefko]

The MusicBee plugin relies on path attribute which is not supported by ownCloud music. But as I was looking into the code, it feels like it is better to make changes in the MusicBee plugin: BlitterStudio/MB_SubSonic#66

[paulijar]

This is now released in Music v1.5.2.