Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop button #911

Closed
pidlug opened this issue Nov 1, 2021 · 9 comments
Closed

Stop button #911

pidlug opened this issue Nov 1, 2021 · 9 comments

Comments

@pidlug
Copy link

pidlug commented Nov 1, 2021

Is it possible to stop listening in addition to pause?
With internet radio I would like to just stop listening to later start from current position, so e.g. news are fresh. Currently the player has only pause button, after pausing and later clicking play it countinues from the place it was paused. Some streams even break when trying to play after pause.
Currently the workaround I use is switching stations to fix the stream or just leaving the Music app.

@paulijar
Copy link
Collaborator

paulijar commented Nov 1, 2021

The stop functionality is there but finding it may not be quite obvious. There are three ways to trigger it:

  1. The media control key "stop" in case your keyboard has one
  2. Keyboard shortcut shift+space
  3. If you are using Chrome, there is the media control popup. Pressing the close button ("X") on the panel stops the playback.
    image

@pidlug
Copy link
Author

pidlug commented Nov 1, 2021

Thanks! I'm on ungoogled-chromium - not sure if media control popup is available.
Other solutions wouldn't work because it is a tablet, without keyboard attached. Could be my use case is not very common...

@paulijar
Copy link
Collaborator

paulijar commented Nov 1, 2021

Okay. Much of the Music web UI is primarily designed for desktop use. Tablet or phone may be used, too, but the UX will be sub-optimal at best. This is especially because many things on the UI are shown only when hovering with a mouse cursor. For tablet use, I would recommend using some Subsonic client.

On Chrome for Android, you can achieve the stop functionality by first pausing the playback, and then swiping off the player control from the system notification center (the "curtain"). I don't know if this works with Chromium, though.

@pidlug
Copy link
Author

pidlug commented Nov 1, 2021

Heh, this "hovering" is more and more used - e.g in Gnome which tries to advertise itself as touchscreen friendly :-(
I agree that it helps to keep user interface clean. Anyway, it would be nice to have a stop button, simple because it does something different than pause and there is enough space to put it - at least on the internet radio player.

@paulijar
Copy link
Collaborator

paulijar commented Nov 1, 2021

While there usually is free space in the controls pane on PC screen and on landscape tablet, the view can be quite crowded already on portrait tablet. Especially while the details pane is shown. And on mobile phone screens, we are chronically low on screen space. For these reasons, I'm not too excited about adding another button to the pane. But maybe there could be context menu shown with a long press on the pause button which would offer the stop option.

@pidlug
Copy link
Author

pidlug commented Nov 7, 2021

I think that long press or double click could be a solution. Thanks.

paulijar added a commit that referenced this issue Nov 13, 2021
Long press on the play/pause button in the controls pane now shows a context
menu with the option "Stop". This is especially to enable stopping on
touch-only devices which have no HW media control keys or the shift button to
use keyboard shortcut.

On touch devices supporting it, there is also a small haptic feedback given
when the context menu opens. It helps to notice that the menu has opened as
the menu itself is often hidden by the user's finger. This seems to currently
work at least on Chrome for Android but not on Firefox for Android.

refs #911
@paulijar
Copy link
Collaborator

The new Music app release v1.5.0 now shows the stop button by long press of the play/pause button. This has been tested to work on the modern PC browsers, on Chorme for Android, and on Firefox for Android. However, handling the long press on touch devices is a bit tricky, and there is a good chance that this doesn't work perfectly or at all on some devices or browsers.

@edmundlaugasson
Copy link

Why not show stop button right away? It is small button and does not take too much space. Please allow it right away without doing anything extra and unlogical. Such pressing and holding is not intuitive. I could not figure out until I found current issue....

@paulijar
Copy link
Collaborator

@edmundlaugasson Well, this is basically already answered above: #911 (comment)

So even if there is plenty of free space when using a full screen window on some 1920p or 4K display, we need to support also many other screen/window sizes. So if we add any new buttons, then those need to be dynamic in the sense that they may need to be hidden on narrower screens. A lot of effort has been put to make these dynamics work fluently with the current controls, and adding any new buttons would require revisiting all this. It would probably be a lot more work than you would imagine, and there are many other features in the queue before this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants