Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for nextcloud 21 #830

Closed
tob123 opened this issue Feb 22, 2021 · 15 comments
Closed

support for nextcloud 21 #830

tob123 opened this issue Feb 22, 2021 · 15 comments

Comments

@tob123
Copy link

tob123 commented Feb 22, 2021

Hello,

the music app is marked as untested on nextcloud 21.
after enabling it I found no issues yet, but perhaps you can share from your end whether nextcloud 21 is supported and update the app or release it accordingly on the nextcloud app store ?

thanks.

Tobias.

@paulijar
Copy link
Collaborator

Nextcloud 21 is not supported yet. When you try to reload the app after the initial load, it should fail. Unfortunately, Nextcloud has broken their API again, and some cumbersome changes are needed to the Music app to properly support NC21. Combine that with the fact that I'm busy with other duties in my life for the next few days, and we come to conclusion that it will probably take 1-3 weeks before NC21 can be supported.

As a general advise, it is usually better to refrain from updating to Nextcloud version X.0.0, unless you are adventurous in mind. The philosophy of NC seems to be to "move fast and break things" and the apps can't hold along. Things will often start to stabilize some 1-2 months after the initial release "X", and then the release "X+1" is already right around the corner, breaking things again.

@tob123
Copy link
Author

tob123 commented Feb 22, 2021

hello paulijar, thanks.
yes, you are right. trying out things with the promised performance improvements tempted me to upgrade.

@JoshuaPettus
Copy link

JoshuaPettus commented Feb 22, 2021

Seeing as this is the most important app for me, I will definitely hold off till at least you are good :) The rest I can work around just fine, but when they break music it's a real drag.

One question though, would PHP 8 be an issue for Music as well?

@paulijar
Copy link
Collaborator

One question though, would PHP 8 be an issue for Music as well?

Music has not been tested with PHP 8. It may or may not work. But I just checked through a list of incompatible changes between PHP 7.4 and PHP 8, and I couldn't immediately notice anything which would affect us. One open question is the compatibility of the getID3 library (used for metadata extraction) with PHP8; I don't know its sources well enough to tell if it uses any of those incompatible constructs.

@JoshuaPettus
Copy link

JoshuaPettus commented Feb 23, 2021

Kinda putting the cart before the horse anyway. :) Hopefully it will work when the time comes.

@tob123
Copy link
Author

tob123 commented Feb 24, 2021

hello, i am on php 7.3 and have no issues using the plugin. as far as I understand nextcloud-server supports 7.3,7,4 and 8 and higher; but does not require php 8.

@JoshuaPettus
Copy link

JoshuaPettus commented Feb 25, 2021

Nope it doesn't, that's just one of the promised performance avenues with NC21 that I'd like to look into later. But it's relatively easy to switch between versions of PHP, can't downgrade an NC server.

Well.. I can from backup, but I'd rather not.. XD

paulijar added a commit that referenced this issue Feb 27, 2021
NC21 wraps all the DBAL exceptions to its own generic exception type. This
makes it a bit trickier to react to unique constraint violations. To not have
to write the cumbersome try-catch-if-else blocks everywhere, both the native
DBAL UniqueConstraintViolationExceptions and the wrapped NC21 exceptions are
now caught as early as possible, and mapped to our own exception type.

refs #830
@paulijar
Copy link
Collaborator

paulijar commented Mar 1, 2021

Version 1.0.3 with support for NC21 is now out!

The new version should work also with PHP 8.0. I haven't actually manually tested this configuration, but the automated tests on the test server succeeded also with PHP 8.0. In those tests, a few mp3 files with metadata tags are scanned with occ music:scan, and then the library is browsed in various ways using the Ampache and Subsonic APIs. As all of this worked without issues, this is a pretty strong sign that at least the basic use cases function as intended. But if you see any problems, then please open new issues.

@paulijar paulijar closed this as completed Mar 1, 2021
@JoshuaPettus
Copy link

Thank you so much for all you do!

@JoshuaPettus
Copy link

Just wanted to let you know it works great. I'm now using it on NC21 with PHP8.0 no issues! (Can't say the same for NC21 XD. There is a fun gotcha with a memory leak in OCC if PHP doesn't have the right setting: apc.enable_cli=1 in /etc/php/X.X/cli/conf.d/20-apcu.ini for those interested.)

@Gomez
Copy link
Member

Gomez commented Mar 12, 2021

Unfortunately it does not work for me: #838

@moviuro
Copy link

moviuro commented Mar 12, 2021

There is a fun gotcha with a memory leak in OCC if PHP doesn't have the right setting: apc.enable_cli=1 in /etc/php/X.X/cli/conf.d/20-apcu.ini for those interested.)

Has this been documented on the nextcloud project?

@JoshuaPettus
Copy link

nextcloud/server#25742

@Gomez
Copy link
Member

Gomez commented Mar 12, 2021

But this is unrelated to my reported bug. I have apc.enable_cli=1 in my config. Still broken Nextcloud after enabling music.

@JoshuaPettus
Copy link

No, It has nothing to do with your issue, just answering moviuro's question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants