Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth2 support #159

Merged
merged 53 commits into from
Nov 7, 2017
Merged

OAuth2 support #159

merged 53 commits into from
Nov 7, 2017

Conversation

nasli
Copy link
Contributor

@nasli nasli commented Jul 11, 2017 •
edited
Loading

Oauth2 support owncloud/ios-legacy#919

@jesmrec jesmrec mentioned this pull request Jul 11, 2017
Closed
9 tasks
@nasli nasli requested a review from davivel July 11, 2017 07:33
@nasli nasli added this to the 2.1.1 milestone Jul 11, 2017
@davivel davivel force-pushed the oauth_support_library branch from 3ecc445 to 5156538 Compare August 25, 2017 09:03
@davivel davivel changed the title [WIP] Oauth2 support OAuth2 support Aug 25, 2017
davivel and others added 19 commits August 25, 2017 12:33
@davivel
Fix typo breaking tests build
757342e
@davivel
Add specific NSError for server in maintenance mode
8f3eac7
@davivel
Add some more HTTP error codes as known constants
f3e8ad4
@davivel
Add OAuth2 errors to UtilsFramework.getErrorById()
1de571b
@nasli
Add refresh token to request
4b5de10
@nasli
Update occommunication to store refresh token and expires in
dd0b249
@nasli
Add retry n tiemes in all network requests
9d7bc7c
@nasli
Use constant to ntimes retry variable
23ba7f2
@nasli
Add new OAuth2 configuration class that manages all OAuth parameters.…
7785619 
… Add oauth refresh token request
@nasli
Update oauth manager class to retry a sucessfull new credentials. Add…
1c173da 
… retry after new credentials also on network main operation with token
@nasli
Add protocol to store new credentials
fd7685d
@nasli
Update credentials to store new tokens
a1c239e
@nasli
Add parameter identifier into credentials object
2e77860
@nasli
Set same userId for new credentials
ebc76ee
@nasli
Refresh token and store new credentials propertly
93c3ba8
@nasli
Update git ignore file to avoid xcshareddata
680bdc4
@nasli
Resume new retry operation and set auth header value instead add to f…
04f3f4f 
…ix and successfully retry newtwork request with the new access token. :)
@nasli
Set redirection block also for retries.
3134037
@nasli
Refactor uploads to retry ntimes
5004bfd
nasli and others added 26 commits September 13, 2017 16:18
@nasli
Add silently retries into downloads network tasks
a9db816
@nasli
Fix network lib issue that report delegate location previous the fail…
e8565c4 
…ure with 401 errors
@nasli
Remove property not longer needed
624428d
@nasli
Use credentials object directly since is no longer needed the full co…
9cd5bf6 
…mmunication object
@nasli
Rename some OAuth methods with accurate description
35fc856
@nasli
Use default message with more information for user
3eb39dc
@nasli
Remove unnecessary class and update references
081d6a9
@nasli
Update store credentials method
feef0d9
@davivel
Merge pull request #162 from owncloud/refresh_oauth_token_library
6ceb273 
Refresh OAuth token and silently retry any request after expiration
@nasli @davivel
Move get auth data to the lib
b745241
@davivel
Complete parameters of access token request, lost in traslation
69d2c1d
@davivel
Prevent cast of nil in completion handler
cc14f97
@davivel
Fix delegate methods handling redirections and authentication challen…
35a3801 
…ges in OAuth2Manager
@davivel
Add protocol for optional check of user-accepted server certificates
eed53c5
@nasli
Merge pull request #163 from owncloud/move_get_access_token_to_lib_li…
6b29fc2 
…brary

Move get access token to lib library
@nasli
Not encode uri
15ce0f1
@nasli
Retry any request after it was cancelled by the system
f6cbe66
@nasli
Test cancelled request
c8a6a27
@nasli
remove detect cancelled error code
077b3e5
@nasli
Fix for server OAuth refresh token responses without required data
88447df
@nasli
Refactor get user data and display name. Add displayName to credentia…
6993f5b 
…ls. Deprecate old methods.
@nasli
Not use handle error class in display name requests
d57639d
@nasli
Fix return request
b434c57
@nasli
Add NSCopying protocol into capabilities class
53ea3ed
@nasli
Test adding cookies to avoid reject from F5
9cb56fb
@pablocarmu
Merge pull request #167 from owncloud/oauth_support_test_cookies_library
16bc3fb 
Add cookies to avoid reject from F5 in OAuth requests
@CLAassistant
Copy link

CLAassistant commented Nov 6, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pablocarmu pablocarmu merged commit f05d1f5 into master Nov 7, 2017
@pablocarmu pablocarmu deleted the oauth_support_library branch November 7, 2017 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablocarmu pablocarmu pablocarmu approved these changes

@davivel davivel Awaiting requested review from davivel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nasli @CLAassistant @pablocarmu @davivel