[feature/avatar] Avatar and generalized resource support #1092
Conversation
- add OCViewHost as container for views provided via OCViewProviders / OCResourceRequests - add view providers for OCAvatar, OCResourceTextPlaceholder - add OCCircularContentView, OCCircularImageView, OCCircularTextView - BookmarkViewController: download a users's avatar and save it in the bookmark - ClientRootViewController: check for an updated version of the user's avatar on every connect - GroupSharingTableViewController: display avatars instead of icons for users - StaticTableViewRow: add support for leading accessory cell - ThemeTableViewCell: extend support for custom layout, revise CellLayouter to support single line of text - remove bolted-on QuickLook thumbnailing (now covered by the new OCResource system) - update static/single login + accounts list UI to work with avatars
|
|
…ager - OCViewHost: improve responsiveness and direct updates (saving unnecessary main runloop cycles), add explicit reload method - ResourceViewHost: subclass of OCViewHost with support for auto-reload on Theme change - ItemPolicyCell, DisplayViewController, ServerListBookmarkCell, ShareClientItemCell, ClientItemCell, NamingViewController, MoreViewHeader: switch from UIImageView and old thumbnail / icon API mix to ResourceViewHost - move ThemeView base class from ownCloudApp to ownCloudAppShared - extend OCAvatar+ViewProvider to OCImage+ViewProvider, so it also returns views for all other OCImages - add ResourceItemIcon and ResourceSourceItemIcons to return TVG resources and provide views for them - VectorImageView: clear layer if not image could be created
|
|
||
| attributedTitle.append(NSAttributedString(string: displayName.appendingFormat("\n"), attributes: [ | ||
| NSAttributedString.Key.font : UIFont.boldSystemFont(ofSize: 24) | ||
| ])) |
There was a problem hiding this comment.
Font size could be set to .title2 (or similar) instead of using float value
There was a problem hiding this comment.
Thanks. Addressed this in 3036f54 in feature/graph-api.
| if let serverName = bookmark.url?.host { | ||
| attributedTitle.append(NSAttributedString(string: serverName, attributes: [ | ||
| NSAttributedString.Key.font : UIFont.systemFont(ofSize: 18) | ||
| ])) |
There was a problem hiding this comment.
Font size could be set to . headline (or similar) instead of using float value
There was a problem hiding this comment.
Thanks. Addressed this in 3036f54 in feature/graph-api.
|
@felix-schwarz I left two small comments, but overall it is an awesome implementation. I love it! Please can you also update the branch and set the correct merge branch? |
Description
Support for avatars, with accompanying minor design tweaks.
Builds upon the SDK's new generalized resource management system that provides a mechanism for retrieving, caching and updating resources such as item thumbnails and avatars.
Related Issue
#408
Related PRs
owncloud/ios-sdk#81
Screenshots (if appropriate):
Single Account View
Dark theme (before) and light theme (after). Avatar support is also available in dark theme, of course.
Multi Account View
Recipients search
Types of changes
Checklist: