feature:remove enable only for specific groups #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw version in master is still at 0.5.2. |
|
I guess the two failing tests are no longer needed? |
|
Not sure when we should rise the version. Unless the PR requires rising the version (maybe because a migration or similar), we can assume the version will increase when the release is done. |
jvillafanez
approved these changes
Dec 13, 2023
|
@jnweiger do we need to rise version now? |
as soon as we have a release ticket for impersonate, this ticket will specify what the new version is. No need to do it per PR. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed at #237, it makes sense to remove the
Enable only for specific groupsapp setting as theImpersonate Settingssection on theUser authenticationpage already gives admin the possibility to select different options for groups admin management.