Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI #330

Merged
merged 3 commits into from
May 23, 2019
Merged

fix CI #330

merged 3 commits into from
May 23, 2019

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented May 23, 2019

Description

  1. stable10 has its own user-management app. so we should tests with that and not using the additional app that is made for master
  2. guest users have to be created by sharing to an email address see cannot add users to guest_app group #331
  3. a failing test probably timing issue see password change test fails with stable10 #332

Motivation and Context

make CI green again

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • tests only

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #330 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #330   +/-   ##
=========================================
  Coverage     17.87%   17.87%           
  Complexity      101      101           
=========================================
  Files            11       11           
  Lines           537      537           
=========================================
  Hits             96       96           
  Misses          441      441

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c34974...2c46d41. Read the comment docs.

@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #330 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #330   +/-   ##
=========================================
  Coverage     17.87%   17.87%           
  Complexity      101      101           
=========================================
  Files            11       11           
  Lines           537      537           
=========================================
  Hits             96       96           
  Misses          441      441

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c34974...0e4f1c2. Read the comment docs.

@individual-it individual-it force-pushed the useStable10BuildInUserManagement branch from b070839 to f08c571 Compare May 23, 2019 05:59
@individual-it individual-it force-pushed the useStable10BuildInUserManagement branch from f08c571 to e8c9ff0 Compare May 23, 2019 06:13
@individual-it individual-it changed the title for stable10 based tests use its build-in user management app gix CI May 23, 2019
@individual-it individual-it changed the title gix CI fix CI May 23, 2019
@individual-it individual-it merged commit 8504351 into master May 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the useStable10BuildInUserManagement branch May 23, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants