Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add occ command to reset for all users #83

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Conversation

tomneedham
Copy link

@tomneedham tomneedham commented Nov 9, 2018

For admins to show new features / clients / manuals to their users, then can theme the firstrunwizard again and trigger it nicely

  • Test on Config class method

@DeepDiver1975
Copy link
Member

occ already has a command to set user preferences .... maybe we add an option --all-users over there?

@tomneedham
Copy link
Author

Possibly - but that feels like handing a loaded gun to admins - at least this is contained to a flag that is expected to be on all users, and has limited impact.

@PVince81
Copy link
Contributor

PVince81 commented Nov 9, 2018

I wonder if we need a base class in core for all commands that apply to all users... The number of commands with "one user", "multiple users" or "multiple group" or "all" as arguments is increasing and we keep on reimplementing.

@tomneedham
Copy link
Author

Rebased

@PVince81
Copy link
Contributor

please take over. goal is just to finish, no need to add further options for now

@PVince81
Copy link
Contributor

@sharidas ^

@PVince81 PVince81 added this to the development milestone Feb 12, 2019
@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #83 into master will increase coverage by 0.59%.
The diff coverage is 30.43%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #83      +/-   ##
============================================
+ Coverage     27.47%   28.07%   +0.59%     
- Complexity       10       16       +6     
============================================
  Files             8        9       +1     
  Lines            91      114      +23     
============================================
+ Hits             25       32       +7     
- Misses           66       82      +16
Impacted Files Coverage Δ Complexity Δ
lib/Command/ResetAll.php 0% <0%> (ø) 4 <4> (?)
lib/config.php 100% <100%> (ø) 9 <2> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c17a10f...e4e4527. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #83 into master will increase coverage by 0.59%.
The diff coverage is 30.43%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #83      +/-   ##
============================================
+ Coverage     27.47%   28.07%   +0.59%     
- Complexity       10       16       +6     
============================================
  Files             8        9       +1     
  Lines            91      114      +23     
============================================
+ Hits             25       32       +7     
- Misses           66       82      +16
Impacted Files Coverage Δ Complexity Δ
lib/Command/ResetAll.php 0% <0%> (ø) 4 <4> (?)
lib/config.php 100% <100%> (ø) 9 <2> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c17a10f...e4e4527. Read the comment docs.

@sharidas
Copy link

sharidas commented Feb 13, 2019

Ouch. I wonder if this is tested. Sorry no offense here. Or may be its missed to commit :). But this app has missing namespace in the info.xml. And as a result the command occ fails. I have updated the PR with the same. Below is the result I have verified in the console:

 sujith@sujith-ownCloud  ~/test/owncloud3   master ●  ./occ firstrunwizard:reset-all
Cannot load Xdebug - it was already loaded
Resetting firstrunwizard for all users
    1 [============================]
Done
 sujith@sujith-ownCloud  ~/test/owncloud3   master ● 

@sharidas
Copy link

@PVince81 The pull request is ready for review. The CI is cleared.

@tomneedham
Copy link
Author

But this app has missing namespace in the info.xml. And as a result the command occ fails.

Nice spot. My guess is a osx vs linux filesystem casing issue I've seen before with the autoloader. So probably worked for me locally but on a linux box it dies. Good catch!

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 3c2656f into master Feb 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/reset-all branch February 13, 2019 13:31
@PVince81
Copy link
Contributor

as firstrunwizard is bundled, we might want to add this addition in the core changelog or release notes only ? @pmaier1

@pmaier1
Copy link

pmaier1 commented Feb 14, 2019

core changelog or release notes

both, plx

@phil-davis
Copy link
Contributor

Backport stable10 #93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants