-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add occ command to reset for all users #83
Conversation
occ already has a command to set user preferences .... maybe we add an option --all-users over there? |
Possibly - but that feels like handing a loaded gun to admins - at least this is contained to a flag that is expected to be on all users, and has limited impact. |
2b657d7
to
3407984
Compare
I wonder if we need a base class in core for all commands that apply to all users... The number of commands with "one user", "multiple users" or "multiple group" or "all" as arguments is increasing and we keep on reimplementing. |
3407984
to
aafcbd1
Compare
Rebased |
please take over. goal is just to finish, no need to add further options for now |
aafcbd1
to
cc1d798
Compare
cc1d798
to
e4e4527
Compare
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
============================================
+ Coverage 27.47% 28.07% +0.59%
- Complexity 10 16 +6
============================================
Files 8 9 +1
Lines 91 114 +23
============================================
+ Hits 25 32 +7
- Misses 66 82 +16
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
============================================
+ Coverage 27.47% 28.07% +0.59%
- Complexity 10 16 +6
============================================
Files 8 9 +1
Lines 91 114 +23
============================================
+ Hits 25 32 +7
- Misses 66 82 +16
Continue to review full report at Codecov.
|
Ouch. I wonder if this is tested. Sorry no offense here. Or may be its missed to commit :). But this app has missing
|
@PVince81 The pull request is ready for review. The CI is cleared. |
Nice spot. My guess is a osx vs linux filesystem casing issue I've seen before with the autoloader. So probably worked for me locally but on a linux box it dies. Good catch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
as firstrunwizard is bundled, we might want to add this addition in the core changelog or release notes only ? @pmaier1 |
both, plx |
Backport |
For admins to show new features / clients / manuals to their users, then can theme the firstrunwizard again and trigger it nicely