[stable6 backport] Permit personal mount points to be used for sharing #9635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An issue existed where `readData` used `OCP\User::getUser()` to get the user for personal mount points, which worked in all situations apart from when a personal mount point was used for sharing, so the return from `getUser()` is not the user that owns the share. As such, any personal mount points would not work correctly when shared. `readData` and `writeData` have been changed from using a `$isPersonal` boolean to using a `$user` string|null. `$isPersonal = false` can now be written as `$user = NULL` (or left out in the case of `readData`), and `$isPersonal = true` can be written as `$user = OCP\User::getUser()`. Backport of abfd7ec from master
|
Please review @Xenopathic @DeepDiver1975 @icewind1991 @karlitschek @craigpg need your approval for this backport. |
This was referenced Jul 15, 2014
|
Code looks good 👍 |
|
The inspection completed: No issues found |
|
👍 (although I wrote it, does it still count? 😆) |
|
Yes, as sanity check. Or you can help test it. Not 100% the same: getBackendStatus does not have the isPersonal arg, but should be fine. |
|
Hmm, I see. I don't think |
|
Yeah, not sure why that argument was added on master. Waiting for @karlitschek 's green light as this is OC6, then we can merge. |
|
yes. please backport |
|
You mean merge 😄 Merging now. |
PVince81
pushed a commit
that referenced
this pull request
Jul 15, 2014
…dData [stable6 backport] Permit personal mount points to be used for sharing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue existed where
readDatausedOCP\User::getUser()to get the userfor personal mount points, which worked in all situations apart from when a
personal mount point was used for sharing, so the return from
getUser()isnot the user that owns the share. As such, any personal mount points would not
work correctly when shared.
readDataandwriteDatahave been changed from using a$isPersonalboolean to using a
$userstring|null.$isPersonal = falsecan now bewritten as
$user = NULL(or left out in the case ofreadData), and$isPersonal = truecan be written as$user = OCP\User::getUser().Backport of abfd7ec from master
Fixes #9535