Make shipped apps updatable via appstore #8808

georgehrke · 2014-05-31T18:07:39Z

Make shipped apps updatable via the appstore. Apps need an ocsid assigned to them. See example file for how to do so. (will add to doc asap).

You can test by:

setting up a new ownCloud
adding the videos app linked below
test different scenarios
- default app dir writable
- default app dir not writable

will remove https://github.com/owncloud/core/pull/8808/files#diff-1225d18e3966cf8859db1978ce38fcaeR508 as soon as there are 2 👍s

please review @DeepDiver1975 @PVince81 @schiesbn

Conflicts: lib/private/app.php lib/private/installer.php

georgehrke · 2014-05-31T20:17:33Z

for testing purposes: videos.zip

DeepDiver1975 · 2014-05-31T20:46:25Z

@georgehrke please add unit test - THX

georgehrke · 2014-05-31T20:47:03Z

will add one on monday

karlitschek · 2014-06-02T13:47:38Z

looks good to me 👍

nickvergessen · 2014-06-02T17:02:39Z

lib/private/app.php

 			}
 		}
-		return false;
+
+		if (count($possibleApps) === 0) {


if (empty($possibleApps)) {

… exists

PVince81 · 2014-06-13T08:14:45Z

The update works now.
When the app store is disabled, the update button is not there.

However, there are the following additional issues:

After the update, the button just disappears. I need to refresh the page to see that the version has updated.
I had my "apps" folder writable, but not "apps/videos". The button still appeared. When clicked, permission denied errors appeared in the log. Then the button disappeared. No error displayed in the UI. Refresh the page: app not updated.

I believe that these issues are probably not directly related to this PR here so I suggest to address these separately.

And not to forget the issue mentionned by @MorrisJobke:
3) Verify certificate

So I'm ok to merge this to move this forward, but the certificate check should be handled before the final release.

georgehrke · 2014-06-13T19:40:58Z

I found one tiny issue, fixing it right now

georgehrke · 2014-06-13T19:49:14Z

any opinion on skipping codeCheck for shipped apps? wasn't sure about it

those apps will have to use the public api

scrutinizer-notifier · 2014-06-13T20:15:41Z

The inspection completed: 9 new issues, 18 updated code elements

ghost · 2014-06-13T20:36:17Z

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/5600/

PVince81 · 2014-06-16T08:41:19Z

I think it's best to keep the code check even for shipped apps, unless there is something unfixable.
But I think even shipped apps should use public API.
Not sure whether they are all fully migrated ?

CC @icewind1991

icewind1991 · 2014-06-16T11:46:57Z

I don't think the shipped apps only use the public api, for now I would say disable the check for shipped apps untill we've fully moved everything to the public api

scrutinizer-notifier · 2014-06-16T11:49:11Z

A new inspection was created.

karlitschek · 2014-06-16T11:55:32Z

Yes. Unfortunately they are not fully migrated to the public api yet. So we have to disable the check for now. Let´s try again for ownCloud 8.

georgehrke · 2014-06-16T11:57:40Z

This means we will have to be super careful when reviewing apps for the app store, as 3rdparty apps could set the shipped flag once installed

ghost · 2014-06-16T13:13:43Z

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/5624/

georgehrke · 2014-06-16T13:51:41Z

ok,
so I disabled the code check for shipped apps,
tests are passing and no rebase is necessary.

Are there any objections left or can this be merged?

PVince81 · 2014-06-16T13:53:51Z

👍 you can merge this but make sure to raise a ticket for handling the HTTPS cert validation part next

Make shipped apps updatable via appstore

PVince81 · 2014-06-16T14:51:17Z

Follow up ticket is here: #9054

georgehrke added 5 commits May 31, 2014 12:17

make it possible to update shipped apps via the appstore

2bcfd8e

Merge branch 'master' into update_shipped_apps_from_appstore

c8636ca

Conflicts: lib/private/app.php lib/private/installer.php

add button for properly uninstalling apps

020255b

Merge branch 'master' into update_shipped_apps_from_appstore

c6dc9ae

read ocsid from shipped apps on install

c8a8c7e

georgehrke changed the title ~~WIP~~ Make shipped apps updatable via appstore May 31, 2014

georgehrke added this to the ownCloud 7 milestone May 31, 2014

georgehrke added High labels May 31, 2014

nickvergessen reviewed Jun 2, 2014
View reviewed changes

lib/private/app.php

}

}

return false;

if (count($possibleApps) === 0) {

Copy link

Contributor

nickvergessen Jun 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (empty($possibleApps)) {

georgehrke added 2 commits June 10, 2014 18:39

don't show update button when appstore is disabled or no writable dir…

5e9fa64

… exists

Update preseed-config.php

0890ce4

skip certain tests for shipped apps

c378e76

don't skip code check for skipped apps

65028c4

those apps will have to use the public api

disable code check for shipped apps

86f546f

georgehrke added a commit that referenced this pull request Jun 16, 2014

Merge pull request #8808 from owncloud/update_shipped_apps_from_appstore

15c215c

Make shipped apps updatable via appstore

georgehrke merged commit 15c215c into master Jun 16, 2014

georgehrke deleted the update_shipped_apps_from_appstore branch June 16, 2014 13:54

georgehrke mentioned this pull request Jun 16, 2014

Improve HTTPS cert validation for appstore #9054

Closed

PVince81 mentioned this pull request Jun 20, 2014

Strange warnings looking for appinfo in the wrong places #9122

Closed

butonic mentioned this pull request Jul 7, 2014

Add ocsid owncloud-archive/search_lucene#28

Merged

butonic added p2-high sev2-high and removed High labels Sep 10, 2014

RobinMcCorkell mentioned this pull request Apr 18, 2015

occ / console.php app:disable deletes app instead of disabling it #8790

Closed

lock bot locked as resolved and limited conversation to collaborators Aug 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make shipped apps updatable via appstore #8808

Make shipped apps updatable via appstore #8808

georgehrke commented May 31, 2014

georgehrke commented May 31, 2014

DeepDiver1975 commented May 31, 2014

georgehrke commented May 31, 2014

karlitschek commented Jun 2, 2014

nickvergessen Jun 2, 2014

PVince81 commented Jun 13, 2014

georgehrke commented Jun 13, 2014

georgehrke commented Jun 13, 2014

scrutinizer-notifier commented Jun 13, 2014

ghost commented Jun 13, 2014

PVince81 commented Jun 16, 2014

icewind1991 commented Jun 16, 2014

scrutinizer-notifier commented Jun 16, 2014

karlitschek commented Jun 16, 2014

georgehrke commented Jun 16, 2014

ghost commented Jun 16, 2014

georgehrke commented Jun 16, 2014

PVince81 commented Jun 16, 2014

PVince81 commented Jun 16, 2014

Make shipped apps updatable via appstore #8808

Make shipped apps updatable via appstore #8808

Conversation

georgehrke commented May 31, 2014

georgehrke commented May 31, 2014

DeepDiver1975 commented May 31, 2014

georgehrke commented May 31, 2014

karlitschek commented Jun 2, 2014

nickvergessen Jun 2, 2014

Choose a reason for hiding this comment

PVince81 commented Jun 13, 2014

georgehrke commented Jun 13, 2014

georgehrke commented Jun 13, 2014

scrutinizer-notifier commented Jun 13, 2014

ghost commented Jun 13, 2014

PVince81 commented Jun 16, 2014

icewind1991 commented Jun 16, 2014

scrutinizer-notifier commented Jun 16, 2014

karlitschek commented Jun 16, 2014

georgehrke commented Jun 16, 2014

ghost commented Jun 16, 2014

georgehrke commented Jun 16, 2014

PVince81 commented Jun 16, 2014

PVince81 commented Jun 16, 2014