use phpseclib from 3rdparty

[DeepDiver1975]

TODO:

• evaluate if 3rdpaty/blowfish can be removed together with the whole legacy migration @schiesbn
• test files_external password encryption - maybe @PVince81 THX
• test files_external sftp - maybe @bantu THX

[karlitschek]

👍 as discussed

[ghost]

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/5036/

[DeepDiver1975]

Test_Encryption_Util::testIsLegacyUser
Undefined offset: 17

/var/lib/jenkins/jobs/pull-request-analyser/workspace@2/apps/files_encryption/3rdparty/Crypt_Blowfish/Blowfish.php:173
/var/lib/jenkins/jobs/pull-request-analyser/workspace@2/apps/files_encryption/3rdparty/Crypt_Blowfish/Blowfish.php:236
/var/lib/jenkins/jobs/pull-request-analyser/workspace@2/apps/files_encryption/lib/crypt.php:557
/var/lib/jenkins/jobs/pull-request-analyser/workspace@2/apps/files_encryption/hooks/hooks.php:105
/var/lib/jenkins/jobs/pull-request-analyser/workspace@2/apps/files_encryption/tests/util.php:224

[ghost]

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/5042/

[ghost]

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/5048/

[ghost]

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/5052/

[DeepDiver1975]

@PVince81 @bantu @schiesbn any change to have a look at the open issues as listed in the description - much appreciated! THX

[ghost]

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/5114/

[bantu]

test files_external sftp

Tested. Working.

[ghost]

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/5159/

[DeepDiver1975]

@karlitschek password encryption in files external is properly working as well. Renaming the conflicting class Crypt_Blowfish is working properly according to unit test execution.

Ready to go from my point of view.

@schiesbn Can you please review the changes to files encryption? THX a lot

[karlitschek]

nice 👍

[schiessle]

looks good 👍

[scrutinizer-notifier]

A new inspection was created.