File list sorting by clicking on column headers

[PVince81]

File list sorting by clicking on column headers.

This PR will contain file list sorting.

• Sortable file list
• Sortable trashbin
• Sortable public page
• Upload file while sorted must appear at the correct position
• Sort indicator on headers (arrows?)
• Clean up server-side comparators ?

[PVince81]

• Client side unit test for sort/reload
• Server side unit test for getFiles() with different sort values

[ghost]

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4052/

[ghost]

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4060/

[ghost]

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4176/

[PVince81]

Fixes #164 #6978

Also TODO:

• make sorting by date the default in the trashbin

[PVince81]

@jancborchardt please have a look, you might want to tweak the styles a bit.
I've added a mouse hover on the column headers and also the triangle icon.

[PVince81]

@DeepDiver1975 @icewind1991 I'm finished with this branch, but it is based off infinite scrolling, which means it will need rebase after infinite scroll is merged.

[ghost]

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4226/

[ghost]

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4228/

[PVince81]

CC @MTRichards

[MTRichards]

Awesome! :)

[icewind1991]

Works great, but why is sorting done server side instead of client side?

[vgezer]

Looks really nice :), but it seems some special characters in languages are not sorted properly. I think it was referred to: #7254

[PVince81]

@icewind1991 client side might be slower especially with many files. Also in the future we might want to have the sorting be done by the database engine, and also the paging (only loading a few results, not the whole list) on the server side as well.

@wakeup yes, you're right.

[PVince81]

Rebased. This is ready for review + testing.

[ghost]

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4482/

[PVince81]

@DeepDiver1975 feel free to hijack this PR... oops too late you already did it. 😉
Just wanted to check whether it was intentional and you didn't submit to the wrong one ?

[PVince81]

@icewind1991 see my comment above about server side sorting. Are you ok with that approach ? Thanks.

[DeepDiver1975]

Just wanted to check whether it was intentional and you didn't submit to the wrong one ?

All intentional here 😉

[icewind1991]

If paging is done server side then sorting should obviously also be done server side but as long as the server sends the full filelist anyway, I would think client side sorting would always be faster since you don't need have an extra ajax request or query the database

[PVince81]

I think the extra ajax request is acceptable when clicking on headers.
Some browsers like IE8 might be quite slow for sorting longer file lists (1000+) on the client-side initially before displaying them.

But one advantage of client-side sorting only would be to have consistent sort, always using an algo on the browser (locale/natural sort)

I would hope that the sorting would be done on the SQL level, but due to the natural sort algos we want to use (and putting the directories first) it is not yet possible.

[ghost]

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4517/

[scrutinizer-notifier]

The inspection completed: 8 new issues, 16 updated code elements

[PVince81]

@icewind1991 besides IE8 there are also mobile browsers which might be slow as well to sort longer list of files.

[PVince81]

@icewind1991 I don't want to throw away the server side sort code just yet for the reasons mentionned above.
It is possible to make it work on the client side with 2-3 extra JS lines later if we ever want it later.
I might add this as part of the "sharing overview" task (on a separate branch) because it uses the OCS Share API that doesn't return sorted results.

[PVince81]

To clarify: the "sharing overview page" uses a subclass of FileList and displays a list of shared files.

[Nowaker]

Any chance it gets merged into version 6?

[karlitschek]

No. This is a complex change that will be part of owncloud 7. We only backport Bugfixes. But you can use the master daily builds as a preview.

[karlitschek]

Ups. Wrong button. Thanks @DeepDiver1975 :-)

[ghost]

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4556/

[DeepDiver1975]

@karlitschek np 😉

[DeepDiver1975]

@owncloud-bot retest this please

[ghost]

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4557/

[PVince81]

As discussed with @karlitschek, server-side sort is the way to go for the files app.

[PVince81]

@icewind1991 can we merge this now ?

[icewind1991]

Yes 👍

[PVince81]

@jancborchardt I didn't receive any feedback about the design so I will merge this first.
The design / look can be tweaked in separate PRs.

[jancborchardt]

@PVince81 better always mention @owncloud/designers instead of just me alone as otherwise I’ll drown in issue notifications. ;)

Anyway, see @jbtbnl’s review at #8551