Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default mimetype detection for storage backends to only use filename #5965

Merged
merged 1 commit into from
Nov 20, 2013

Conversation

icewind1991
Copy link
Contributor

This speeds up mimetype detection for external storages in some cases.

cc @karlitschek @DeepDiver1975

@karlitschek
Copy link
Contributor

👍

@karlitschek
Copy link
Contributor

@PVince81 @schiesbn What do you think?

@PVince81
Copy link
Contributor

Does it mean that even for local storages we don't use the "file" command any more ?

@karlitschek
Copy link
Contributor

@PVince81 Yes. That's the idea. I don't think we need it at all.

@PVince81
Copy link
Contributor

Ok I'll test this with SFTP. I expect the scanning should become almost as fast as I observed yesterday in #5954

@ghost
Copy link

ghost commented Nov 20, 2013

Test passed.
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/2048/

@PVince81
Copy link
Contributor

70 pics, 7 seconds to scan (instead of minutes) ! Well done ! 👍

PVince81 pushed a commit that referenced this pull request Nov 20, 2013
Change default mimetype detection for storage backends to only use filename
@PVince81 PVince81 merged commit a88aec8 into master Nov 20, 2013
@PVince81 PVince81 deleted the mimetype-only-path branch November 20, 2013 16:11
@lock lock bot locked as resolved and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants