Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] Revert "Remove fsweb.test.owncloud.com SMB PHP unit test pipeline" #40570

Merged
merged 6 commits into from
Jan 11, 2023

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 10, 2023

Description

This reverts commit 9158e23.

The Windows SMB-based PHP unit test pipeline was temporarily removed by PR #40426

  1. revert the commit, so that the pipeline runs again
  2. point the pipeline config to the new test Windows SMB server.

The values used to access the test Windows SMB server are stored in secrets in the drone owncloud/core repo settings, so that they are not generally available for people to use to store their own files!

SMB_WINDOWS_DOMAIN
SMB_WINDOWS_HOST
SMB_WINDOWS_USERNAME
SMB_WINDOWS_PWD
SMB_WINDOWS_SHARE_NAME

The test pipeline feeds the values of these secrets into the config that files_external uses to access the test Windows SMB share.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Jan 10, 2023
@phil-davis phil-davis changed the title [tests-only] Revert "Remove fsweb.test.owncloud.com SMB PHP unit test pipeline" [tests-only] [full-ci] Revert "Remove fsweb.test.owncloud.com SMB PHP unit test pipeline" Jan 10, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 67e8237 into master Jan 11, 2023
@delete-merged-branch delete-merged-branch bot deleted the enable-smb-php-unit-test-pipeline-again branch January 11, 2023 02:00
@jnweiger
Copy link
Contributor

Confirmed fixed.
With wnd.testlab.owncloud.works down, we get
grafik


With wnd.testlab.owncloud.works up, we get
grafik

Thanks, @GeraldLeikam & @phil-davis

@jnweiger jnweiger mentioned this pull request Sep 11, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants