Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Bump punic/punic from 3.7.0 to 3.8.0 #40448

Merged
merged 4 commits into from
Nov 15, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 24, 2022

Bumps punic/punic from 3.7.0 to 3.8.0.

Release notes

Sourced from punic/punic's releases.

v3.8.0

Changelog

Sourced from punic/punic's changelog.

3.8.0 (2022-10-19)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies php Pull requests that update Php code labels Oct 24, 2022
@dependabot dependabot bot requested a review from phil-davis October 24, 2022 22:05
@phil-davis phil-davis changed the title Bump punic/punic from 3.7.0 to 3.8.0 [full-ci] Bump punic/punic from 3.7.0 to 3.8.0 Oct 25, 2022
@phil-davis
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/composer/punic/punic-3.8.0 branch from a2825fb to 12f046e Compare October 25, 2022 05:06
@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/core/37113/9/7

There were 21 failures:

1) Test\DateTimeFormatterTest::testFormatDateTime with data set #0 (1350129205, null, 'October 13, 2012 at 11:53:25 AM UTC')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'October 13, 2012 at 11:53:25 AM UTC'
+'October 13, 2012, 11:53:25 AM UTC'

/drone/src/tests/lib/DateTimeFormatterTest.php:166
phpvfscomposer:///drone/src/lib/composer/phpunit/phpunit/phpunit:97
...

something has changed with the date format locales/defaults.

@phil-davis phil-davis force-pushed the dependabot/composer/punic/punic-3.8.0 branch from 5ad2866 to 6542cf4 Compare November 14, 2022 08:06
@owncloud owncloud deleted a comment from update-docs bot Nov 14, 2022
@phil-davis phil-davis mentioned this pull request Nov 14, 2022
@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/core/37268/9/7

There were 16 failures:

1) Test\DateTimeFormatterTest::testFormatDateTime with data set #0 (1350129205, null, 'October 13, 2012, 11:53:25 AM UTC')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'October 13, 2012, 11:53:25 AM UTC'
+'October 13, 2012, 11:53:25 AM UTC'
...

The expected and actual strings look the same, but there are some special characters in the actual strings.
Needs investigation.

Bumps [punic/punic](https://github.com/punic/punic) from 3.7.0 to 3.8.0.
- [Release notes](https://github.com/punic/punic/releases)
- [Changelog](https://github.com/punic/punic/blob/main/CHANGELOG.md)
- [Commits](punic/punic@3.7.0...3.8.0)

---
updated-dependencies:
- dependency-name: punic/punic
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@phil-davis phil-davis force-pushed the dependabot/composer/punic/punic-3.8.0 branch from 6542cf4 to 1eb6659 Compare November 15, 2022 06:09
@phil-davis
Copy link
Contributor

A bit of investigation:

1) Test\DateTimeFormatterTest::testFormatDateTime with data set #0 (1350129205, null, 'October 13, 2012, 11:53:25 AM UTC')
expected: 4f63746f6265722031332c20323031322c2031313a35333a323520414d20555443
  actual: 4f63746f6265722031332c20323031322c2031313a35333a3235e280af414d20555443
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'October 13, 2012, 11:53:25 AM UTC'
+'October 13, 2012, 11:53:25 AM UTC'

The actual string returned has "e280af" between the time "11:53:25" and the letters "AM".

https://bugs.php.net/bug.php?id=77914 (the change in this PR is not related to that non-bug, but the bug comments are useful)
"e280af" represents a NARROW NO-BREAK SPACE

It seems that the latest databases that punic is now using are putting this Unicode character within the time string. That seems reasonable - we do not want date-time strings to be wrapped at that point. For example:

We worked most of the morning and then looked at our phones and it was October 13, 2012, 11:53:25
AM UTC. We had to run to catch the train.

With the NARROW NO-BREAK SPACE we would get:

We worked most of the morning and then looked at our phones and it was October 13, 2012,
11:53:25 AM UTC. We had to run to catch the train.

And that is a smarter wrap of the date-time string.

I will adjust the test expectations.

@phil-davis phil-davis force-pushed the dependabot/composer/punic/punic-3.8.0 branch from 1eb6659 to e81869e Compare November 15, 2022 07:29
@phil-davis
Copy link
Contributor

I also pushed a commit to update symfony dependencies that are waiting:

Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 9 updates, 0 removals
  - Upgrading roave/security-advisories (dev-master 1d3484a => dev-master 5317244)
  - Upgrading symfony/console (v4.4.47 => v4.4.48)
  - Upgrading symfony/polyfill-iconv (v1.26.0 => v1.27.0)
  - Upgrading symfony/polyfill-intl-idn (v1.26.0 => v1.27.0)
  - Upgrading symfony/polyfill-intl-normalizer (v1.26.0 => v1.27.0)
  - Upgrading symfony/polyfill-mbstring (v1.26.0 => v1.27.0)
  - Upgrading symfony/polyfill-php72 (v1.26.0 => v1.27.0)
  - Upgrading symfony/polyfill-php73 (v1.26.0 => v1.27.0)
  - Upgrading symfony/polyfill-php80 (v1.26.0 => v1.27.0)
Writing lock file

@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/core/37279/23/7 fails due to known issue #40457 - I will manually change the drone result to a pass, and then merge this PR.

@phil-davis phil-davis merged commit 36fd378 into master Nov 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the dependabot/composer/punic/punic-3.8.0 branch November 15, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant