Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Remove the similar step for exporting mount storage #40435

Merged

Conversation

grgprarup
Copy link
Contributor

Description

This PR removes the step Given the administrator has created a json file with exported config of local storage mount "TestMountPoint" to "mountConfig.json" in temporary storage as this step can be achieved using two steps Given the administrator has exported the local storage mounts using the occ command and And the administrator has created a file "exportedMounts.json" in temporary storage with the last exported content using the testing API, also the latter two steps are more useful than the first single step.

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally
  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@grgprarup grgprarup self-assigned this Oct 19, 2022
@grgprarup grgprarup force-pushed the consolidate-export-config-of-local-storage-test-step branch 4 times, most recently from 88b8afc to a4147eb Compare October 20, 2022 02:30
@grgprarup grgprarup marked this pull request as ready for review October 20, 2022 03:54
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so with this, can we export a dedicated mount(local|external) in the tests?

@grgprarup grgprarup force-pushed the consolidate-export-config-of-local-storage-test-step branch from a4147eb to 47b82b8 Compare October 25, 2022 06:04
@grgprarup
Copy link
Contributor Author

so with this, can we export a dedicated mount(local|external) in the tests?

No, we can't export a dedicated mount point.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kiranparajuli589
Copy link
Contributor

kiranparajuli589 commented Oct 25, 2022

so with this, can we export a dedicated mount(local|external) in the tests?

No, we can't export a dedicated mount point.

imho....that is not true. but if we don't need that mount point dedicated step...it's good to cleanup 👍 .

@grgprarup
Copy link
Contributor Author

so with this, can we export a dedicated mount(local|external) in the tests?

No, we can't export a dedicated mount point.

imho....that is not true. but if we don't need that mount point dedicated step...it's good to cleanup +1 .

I mean to say there is no step for dedicated export. I think we don't need a dedicated export step for now. But we can add it if needed.

@grgprarup grgprarup force-pushed the consolidate-export-config-of-local-storage-test-step branch from 47b82b8 to 9735090 Compare October 31, 2022 03:56
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@grgprarup grgprarup force-pushed the consolidate-export-config-of-local-storage-test-step branch from 9735090 to c2cf99b Compare November 3, 2022 05:10
@grgprarup grgprarup changed the title [tests-only] [full-ci] Remove the similar step for exporting mount storage [tests-only] Remove the similar step for exporting mount storage Nov 7, 2022
@grgprarup grgprarup force-pushed the consolidate-export-config-of-local-storage-test-step branch from c2cf99b to 3d51756 Compare November 7, 2022 06:03
@grgprarup
Copy link
Contributor Author

The PR is passed with full-ci (https://drone.owncloud.com/owncloud/core/37191) except for the PHP-unit test failure with the issue #40457. I have removed the tag full-ci to get CI green and this PR can be merged.

@grgprarup grgprarup requested a review from phil-davis November 7, 2022 06:15
@phil-davis phil-davis merged commit a054d52 into master Nov 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the consolidate-export-config-of-local-storage-test-step branch November 7, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consolidate export config of local storage test steps
6 participants