-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only] Remove the similar step for exporting mount storage #40435
[tests-only] Remove the similar step for exporting mount storage #40435
Conversation
88b8afc
to
a4147eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so with this, can we export a dedicated mount(local|external) in the tests?
tests/acceptance/features/cliExternalStorage/filesExternalWebdavOwncloud.feature
Outdated
Show resolved
Hide resolved
a4147eb
to
47b82b8
Compare
No, we can't export a dedicated mount point. |
Kudos, SonarCloud Quality Gate passed! |
imho....that is not true. but if we don't need that mount point dedicated step...it's good to cleanup 👍 . |
I mean to say there is no step for dedicated export. I think we don't need a dedicated export step for now. But we can add it if needed. |
47b82b8
to
9735090
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
9735090
to
c2cf99b
Compare
c2cf99b
to
3d51756
Compare
The PR is passed with |
Description
This PR removes the step
Given the administrator has created a json file with exported config of local storage mount "TestMountPoint" to "mountConfig.json" in temporary storage
as this step can be achieved using two stepsGiven the administrator has exported the local storage mounts using the occ command
andAnd the administrator has created a file "exportedMounts.json" in temporary storage with the last exported content using the testing API
, also the latter two steps are more useful than the first single step.Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: