Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] tests for file version and upload to share #38240

Merged
merged 1 commit into from
Dec 24, 2020
Merged

[tests-only] tests for file version and upload to share #38240

merged 1 commit into from
Dec 24, 2020

Conversation

swoichha
Copy link
Contributor

@swoichha swoichha commented Dec 21, 2020 •
edited
Loading

Description

Added tests for:

  • overwriting a file as share receiver
  • sharer deletes file uploaded by sharee
  • sharer downloads file uploaded by sharee to shared folder

Related Issue

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@swoichha swoichha self-assigned this Dec 21, 2020
@swoichha swoichha mentioned this pull request Dec 21, 2020
Closed
@swoichha swoichha force-pushed the tests-update-share branch 3 times, most recently from 9ee0918 to c444159 Compare December 22, 2020 09:34
haribhandari07
haribhandari07 reviewed Dec 22, 2020
View reviewed changes
tests/acceptance/features/apiShareOperationsToShares/uploadToShare.feature Outdated

Scenario Outline: Sharer can download file uploaded with read/write permission by sharee to a shared folder
Given using <dav-path> DAV path
And user "Brian" has been created with default attributes and without skeleton files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this issue but I think And user "Brian" has been created with default attributes and without skeleton files can be kept in the background.

@swoichha swoichha force-pushed the tests-update-share branch 2 times, most recently from bc5aabe to c90f05f Compare December 23, 2020 05:17
Talank
Talank reviewed Dec 23, 2020
View reviewed changes
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

individual-it
individual-it previously requested changes Dec 23, 2020
View reviewed changes
tests/acceptance/features/apiShareUpdateToShares/updateShare.feature Show resolved Hide resolved
tests/acceptance/features/apiShareOperationsToShares/uploadToShare.feature Outdated
| permissions | change |
| shareWith | Brian |
And user "Brian" has accepted share "/FOLDER" offered by user "Alice"
And user "Brian" has uploaded file with content "some content" to "/Shares/FOLDER/textFile.txt"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels like that should be the When step, as we really want to check the upload
we can check the response code of that step and the content for both "Alice" and "Brian" with
@Then /^the content of file "([^"]*)" for user "([^"]*)" should be:$/

same in other tests

@jasson99
Copy link
Contributor

other than the places where artur commented, looks good.

jasson99
jasson99 reviewed Dec 23, 2020
View reviewed changes
Copy link
Contributor

@jasson99 jasson99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

phil-davis
phil-davis reviewed Dec 23, 2020
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will put the line back and rebase/squash.

tests/acceptance/features/apiShareOperationsToShares/uploadToShare.feature Outdated
@@ -6,7 +6,6 @@ Feature: sharing
And auto-accept shares has been disabled
And user "Alice" has been created with default attributes and skeleton files


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to put this line back, otherwise all the line numbers below will change.

@phil-davis phil-davis dismissed individual-it’s stale review December 23, 2020 14:25

changes have been done

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit ecd072d into master Dec 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the tests-update-share branch December 24, 2020 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasson99 jasson99 jasson99 left review comments

@Talank Talank Talank left review comments

@phil-davis phil-davis phil-davis approved these changes

@haribhandari07 haribhandari07 Awaiting requested review from haribhandari07

@dpakach dpakach Awaiting requested review from dpakach

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@swoichha swoichha

Labels
3 - To Review QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@swoichha @jasson99 @phil-davis @individual-it @dpakach @Talank @haribhandari07