Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Improve error reporting for various tests #37865

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

haribhandari07
Copy link
Contributor

@haribhandari07 haribhandari07 commented Sep 1, 2020

Description

This PR adds resonable response to failing api test output in ocis.
For eg;
Notice: Undefined index: value in /drone/src/tmp/testrunner/tests/acceptance/features/bootstrap/WebDav.php line 3550

and

Undefined index: username in /srv/app/testrunner/tests/acceptance/features/bootstrap/Provisioning.php line 855

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@haribhandari07 haribhandari07 self-assigned this Sep 1, 2020
@haribhandari07 haribhandari07 marked this pull request as ready for review September 1, 2020 08:16
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #37865 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37865   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19403    19403           
=========================================
  Files          1285     1285           
  Lines         75819    75819           
  Branches       1336     1336           
=========================================
  Hits          49096    49096           
  Misses        26329    26329           
  Partials        394      394           
Flag Coverage Δ Complexity Δ
#javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <ø> (ø) 19403.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a42743c...efad351. Read the comment docs.

@phil-davis phil-davis force-pushed the improve-error-handling branch from efad351 to be748c9 Compare September 1, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants