Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Fix phpstan.neon after phpstan 0.12.33 release #37709

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jul 20, 2020

Description

CI is failing, e.g. https://drone.owncloud.com/owncloud/core/25992/4/7

php -d zend.enable_gc=0 vendor-bin/phpstan/vendor/bin/phpstan analyse --memory-limit=2G --configuration=./phpstan.neon --level=0 apps core settings lib/private lib/public ocs ocs-provider
 -- --------------------------------------------------------------------------- 
     Error                                                                      
 -- --------------------------------------------------------------------------- 
     Ignored error #Unsafe usage of new static().# has an unescaped '()' which  
     leads to ignoring all errors. Use '\(\)' instead.                          
 -- --------------------------------------------------------------------------- 

 [ERROR] Found 1 error                 

phpstan https://github.com/phpstan/phpstan/releases/tag/0.12.33 now reports what is actually a problem in phpstan.neon

Fix it and also remove items from excludes_analyse that can now be analysed by phpstan.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis merged commit 3e722d5 into master Jul 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-phpstan branch July 20, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants