[Tests-Only] Fix phpstan settings for 0.12.27 #37500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
phil-davis
commented
Jun 9, 2020
Comment on lines
-16
to
-19
| - %currentWorkingDirectory%/apps/files_external/lib/Lib/Backend/DAV.php | ||
| - %currentWorkingDirectory%/apps/files_external/lib/Lib/Backend/Google.php | ||
| - %currentWorkingDirectory%/apps/files_external/lib/Lib/Backend/SMB.php | ||
| - %currentWorkingDirectory%/apps/files_external/lib/Lib/Backend/SMB_OC.php |
There was a problem hiding this comment.
Note: these had been added to excludes_analyse yesterday, because phpstan 0.12.26 could not analyse them successfully. Now 0.12.27 does analyze them OK.
The other lines that are deleted are for code that is nowadays successfully analyzed by some new/recent phpstan version.
Codecov Report
@@ Coverage Diff @@
## master #37500 +/- ##
=========================================
Coverage 64.68% 64.68%
Complexity 19336 19336
=========================================
Files 1277 1277
Lines 75535 75535
Branches 1331 1331
=========================================
Hits 48860 48860
Misses 26283 26283
Partials 392 392
Continue to review full report at Codecov.
|
individual-it
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
phpstanhttps://github.com/phpstan/phpstan/releases/tag/0.12.27 was released last night. That fixed some problems with0.12.26so now we can reverse some of the changes that were made yesterday to make0.12.26pass.Related Issue
How Has This Been Tested?
Types of changes
Checklist: