Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] add phpstan drop php 7.0 #35788

Closed
wants to merge 11 commits into from

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jul 9, 2019

PRs
#35774 Introduce phpstan - note: has now been merged into stable10
#35786 drop PHP 7.0
together.

To see if it all works.

@phil-davis phil-davis self-assigned this Jul 9, 2019
@phil-davis phil-davis changed the title Stable10 add phpstan drop php 7.0 [stable10] add phpstan drop php 7.0 Jul 9, 2019
@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #35788 into stable10 will increase coverage by 0.33%.
The diff coverage is 75%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35788      +/-   ##
==============================================
+ Coverage       64.84%   65.17%   +0.33%     
+ Complexity      20243    20194      -49     
==============================================
  Files            1299     1298       -1     
  Lines           77220    77125      -95     
  Branches         1301     1301              
==============================================
+ Hits            50070    50266     +196     
+ Misses          26765    26474     -291     
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.37% <75%> (+0.37%) 20194 <41> (-49) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Session/Session.php 100% <ø> (ø) 5 <0> (ø) ⬇️
lib/private/DB/MigrationService.php 90.44% <ø> (ø) 53 <0> (ø) ⬇️
lib/private/DB/ConnectionFactory.php 90.27% <ø> (+7.38%) 21 <0> (ø) ⬇️
lib/private/Session/CryptoWrapper.php 47.05% <ø> (ø) 6 <0> (ø) ⬇️
core/Command/Maintenance/DataFingerprint.php 100% <ø> (ø) 4 <0> (ø) ⬇️
lib/private/Files/Node/Folder.php 96.15% <ø> (-0.03%) 45 <0> (ø)
lib/private/Files/Cache/Wrapper/CacheWrapper.php 89.06% <ø> (+2.69%) 29 <0> (-1) ⬇️
apps/systemtags/appinfo/app.php 14.28% <ø> (ø) 0 <0> (ø) ⬇️
core/Command/Group/AddMember.php 100% <ø> (ø) 9 <0> (ø) ⬇️
lib/private/legacy/util.php 70.18% <ø> (+2.84%) 239 <0> (-2) ⬇️
... and 104 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 305a8ec...3212d25. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #35788 into stable10 will increase coverage by 0.07%.
The diff coverage is 70%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35788      +/-   ##
==============================================
+ Coverage       65.09%   65.17%   +0.07%     
+ Complexity      20239    20194      -45     
==============================================
  Files            1300     1298       -2     
  Lines           77238    77125     -113     
  Branches         1301     1301              
==============================================
- Hits            50279    50266      -13     
+ Misses          26574    26474     -100     
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.37% <70%> (+0.08%) 20194 <11> (-45) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/ConnectionFactory.php 90.27% <ø> (+7.38%) 21 <0> (ø) ⬇️
index.php 0% <0%> (ø) 0 <0> (ø) ⬇️
console.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/DB/MySqlTools.php 88.46% <82.35%> (+88.46%) 11 <11> (+7) ⬆️
lib/private/DB/OCPostgreSqlPlatform.php 24.13% <0%> (-72.42%) 15% <0%> (ø)
lib/private/DB/Connection.php 67.64% <0%> (-2.21%) 49% <0%> (ø)
lib/private/Comments/Manager.php 95.76% <0%> (-0.02%) 73% <0%> (-1%)
lib/private/DB/MDB2SchemaWriter.php 94.79% <0%> (+1.04%) 34% <0%> (ø) ⬇️
lib/private/Repair/Collation.php 87.5% <0%> (+5%) 12% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d2dbc1...669c7a3. Read the comment docs.

@phil-davis
Copy link
Contributor Author

CI green - great stuff.
This is a working example of phpstan and dropping PHP 7.0 on stable10

@phil-davis phil-davis force-pushed the stable10-add-phpstan-drop-php-7.0-20190709 branch from 3212d25 to 669c7a3 Compare July 10, 2019 14:24
@phil-davis
Copy link
Contributor Author

After rebase just now, this PR ends up the same as #35786
I will close here after the CI result comes.

@phil-davis phil-davis closed this Jul 10, 2019
@phil-davis phil-davis deleted the stable10-add-phpstan-drop-php-7.0-20190709 branch July 10, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants