-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable10] add phpstan drop php 7.0 #35788
Conversation
Codecov Report
@@ Coverage Diff @@
## stable10 #35788 +/- ##
==============================================
+ Coverage 64.84% 65.17% +0.33%
+ Complexity 20243 20194 -49
==============================================
Files 1299 1298 -1
Lines 77220 77125 -95
Branches 1301 1301
==============================================
+ Hits 50070 50266 +196
+ Misses 26765 26474 -291
Partials 385 385
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## stable10 #35788 +/- ##
==============================================
+ Coverage 65.09% 65.17% +0.07%
+ Complexity 20239 20194 -45
==============================================
Files 1300 1298 -2
Lines 77238 77125 -113
Branches 1301 1301
==============================================
- Hits 50279 50266 -13
+ Misses 26574 26474 -100
Partials 385 385
Continue to review full report at Codecov.
|
CI green - great stuff. |
Since the DBAL update, the schema wrapper is not needed any more.
Unit tests to verify implementation of mb4 detection without touching the database.
… merged and released
3212d25
to
669c7a3
Compare
After rebase just now, this PR ends up the same as #35786 |
PRs
#35774 Introduce phpstan - note: has now been merged into
stable10
#35786 drop PHP 7.0
together.
To see if it all works.