Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Add explicit PHPUnit asserts to unit tests flagged as 'risky' by PHPUnit6 #34876

Merged

Conversation

phil-davis
Copy link
Contributor

Backport #34871

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #34876 into stable10 will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34876      +/-   ##
==============================================
+ Coverage       63.96%   64.23%   +0.27%     
  Complexity      19901    19901              
==============================================
  Files            1277     1277              
  Lines           76270    76270              
  Branches         1292     1292              
==============================================
+ Hits            48784    48993     +209     
+ Misses          27107    26898     -209     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.2% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.4% <ø> (+0.3%) 19901 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...eratedfilesharing/lib/Middleware/OcmMiddleware.php 77.27% <ø> (ø) 20 <0> (ø) ⬇️
lib/private/Share/Share.php 71.2% <0%> (+0.06%) 507% <0%> (ø) ⬇️
lib/private/Server.php 86.65% <0%> (+0.11%) 253% <0%> (ø) ⬇️
lib/private/DB/QueryBuilder/QueryBuilder.php 91.34% <0%> (+0.48%) 68% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaWriter.php 93.75% <0%> (+1.04%) 34% <0%> (ø) ⬇️
apps/files_trashbin/lib/Expiration.php 98.27% <0%> (+1.72%) 29% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaManager.php 91.22% <0%> (+1.75%) 17% <0%> (ø) ⬇️
lib/private/Files/Cache/Cache.php 97.61% <0%> (+1.79%) 110% <0%> (ø) ⬇️
lib/private/AllConfig.php 94.52% <0%> (+2.05%) 43% <0%> (ø) ⬇️
lib/private/Repair/RepairInvalidShares.php 100% <0%> (+2.73%) 17% <0%> (ø) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61854e2...224ab26. Read the comment docs.

@phil-davis phil-davis force-pushed the stable10-add-assert-to-risky-unit-tests-phpunit-5 branch from 47e6266 to 7c0d712 Compare March 24, 2019 04:45
@phil-davis phil-davis force-pushed the stable10-add-assert-to-risky-unit-tests-phpunit-5 branch from 7c0d712 to 224ab26 Compare March 25, 2019 05:12
@phil-davis
Copy link
Contributor Author

PR in master has been approved and merged. This backport awaits approval.

@phil-davis phil-davis merged commit 2f74254 into stable10 Mar 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-add-assert-to-risky-unit-tests-phpunit-5 branch March 28, 2019 15:28
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants