Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assert to risky unit tests (with PHPUnit6) #34870

Closed
wants to merge 6 commits into from
Closed

Add assert to risky unit tests (with PHPUnit6) #34870

wants to merge 6 commits into from

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Mar 22, 2019 •
edited
Loading

Description

Same as #34871 - and that is out for review. If that is merged, then this PR will "go away"

Sits on top of PR #34860

Related Issue

Motivation and Context

How Has This Been Tested?

Local unit test runs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis phil-davis self-assigned this Mar 22, 2019
@phil-davis phil-davis changed the title Add assert to risky unit tests Add assert to risky unit tests (with PHPUnit6) Mar 22, 2019
@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #34870 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34870      +/-   ##
============================================
- Coverage     65.35%   65.34%   -0.01%     
+ Complexity    18484    18481       -3     
============================================
  Files          1208     1208              
  Lines         69969    70035      +66     
  Branches       1280     1280              
============================================
+ Hits          45727    45766      +39     
- Misses        23870    23897      +27     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.75% <ø> (-0.01%) 18481 <ø> (-3)
Impacted Files Coverage Δ Complexity Δ
...eratedfilesharing/lib/Middleware/OcmMiddleware.php 77.27% <ø> (ø) 20 <0> (ø) ⬇️
...pps/comments/tests/unit/Dav/RootCollectionTest.php 98.38% <ø> (ø) 18 <0> (ø) ⬇️
...mments/tests/unit/Dav/EntityTypeCollectionTest.php 100% <ø> (ø) 7 <0> (ø) ⬇️
tests/bootstrap.php 0% <ø> (ø) 0 <0> (ø) ⬇️
...s/comments/tests/unit/Dav/EntityCollectionTest.php 100% <ø> (ø) 8 <0> (ø) ⬇️
apps/dav/lib/CardDAV/SyncService.php 45.04% <0%> (-2.58%) 27% <0%> (ø)
lib/private/Repair/MoveAvatarOutsideHome.php 35.55% <0%> (-1.95%) 12% <0%> (ø)
apps/dav/lib/DAV/PublicAuth.php 16.66% <0%> (-1.52%) 5% <0%> (ø)
lib/private/Security/CertificateManager.php 87.91% <0%> (-0.98%) 36% <0%> (ø)
lib/private/L10N/L10N.php 85.41% <0%> (-0.86%) 4% <0%> (-1%)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa3a310...2e93168. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #34870 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34870      +/-   ##
============================================
- Coverage     65.35%   65.34%   -0.01%     
+ Complexity    18484    18481       -3     
============================================
  Files          1208     1208              
  Lines         69969    70035      +66     
  Branches       1280     1280              
============================================
+ Hits          45727    45766      +39     
- Misses        23870    23897      +27     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.75% <ø> (-0.01%) 18481 <ø> (-3)
Impacted Files Coverage Δ Complexity Δ
...eratedfilesharing/lib/Middleware/OcmMiddleware.php 77.27% <ø> (ø) 20 <0> (ø) ⬇️
...pps/comments/tests/unit/Dav/RootCollectionTest.php 98.38% <ø> (ø) 18 <0> (ø) ⬇️
...mments/tests/unit/Dav/EntityTypeCollectionTest.php 100% <ø> (ø) 7 <0> (ø) ⬇️
tests/bootstrap.php 0% <ø> (ø) 0 <0> (ø) ⬇️
...s/comments/tests/unit/Dav/EntityCollectionTest.php 100% <ø> (ø) 8 <0> (ø) ⬇️
apps/dav/lib/CardDAV/SyncService.php 45.04% <0%> (-2.58%) 27% <0%> (ø)
lib/private/Repair/MoveAvatarOutsideHome.php 35.55% <0%> (-1.95%) 12% <0%> (ø)
apps/dav/lib/DAV/PublicAuth.php 16.66% <0%> (-1.52%) 5% <0%> (ø)
lib/private/Security/CertificateManager.php 87.91% <0%> (-0.98%) 36% <0%> (ø)
lib/private/L10N/L10N.php 85.41% <0%> (-0.86%) 4% <0%> (-1%)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa3a310...2e93168. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 22, 2019 •
edited
Loading

Codecov Report

Merging #34870 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34870      +/-   ##
============================================
- Coverage     65.35%   65.34%   -0.01%     
+ Complexity    18484    18481       -3     
============================================
  Files          1208     1208              
  Lines         69969    70035      +66     
  Branches       1280     1280              
============================================
+ Hits          45727    45765      +38     
- Misses        23870    23898      +28     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.75% <ø> (-0.01%) 18481 <ø> (-3)
Impacted Files Coverage Δ Complexity Δ
...eratedfilesharing/lib/Middleware/OcmMiddleware.php 77.27% <ø> (ø) 20 <0> (ø) ⬇️
...pps/comments/tests/unit/Dav/RootCollectionTest.php 98.38% <ø> (ø) 18 <0> (ø) ⬇️
...mments/tests/unit/Dav/EntityTypeCollectionTest.php 100% <ø> (ø) 7 <0> (ø) ⬇️
tests/bootstrap.php 0% <ø> (ø) 0 <0> (ø) ⬇️
...s/comments/tests/unit/Dav/EntityCollectionTest.php 100% <ø> (ø) 8 <0> (ø) ⬇️
apps/dav/lib/CardDAV/SyncService.php 45.04% <0%> (-2.58%) 27% <0%> (ø)
lib/private/Repair/MoveAvatarOutsideHome.php 35.55% <0%> (-1.95%) 12% <0%> (ø)
apps/dav/lib/DAV/PublicAuth.php 16.66% <0%> (-1.52%) 5% <0%> (ø)
lib/private/Security/CertificateManager.php 87.91% <0%> (-0.98%) 36% <0%> (ø)
lib/private/L10N/L10N.php 85.41% <0%> (-0.86%) 4% <0%> (-1%)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2a5fec...4807fc9. Read the comment docs.

@phil-davis phil-davis force-pushed the add-assert-to-risky-unit-tests branch from 37d2126 to 4807fc9 Compare March 22, 2019 08:45
@phil-davis
Copy link
Contributor Author

No longer needed. PR #34871 has been merged.

@phil-davis phil-davis closed this Mar 28, 2019
@phil-davis phil-davis deleted the add-assert-to-risky-unit-tests branch March 28, 2019 15:36
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@phil-davis phil-davis

Labels
2 - Developing dev:phpunit-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@phil-davis