[do not merge] Demo incorrect phpunit status (phpunit 6) #34865
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #34865 +/- ##
=============================================
- Coverage 65.35% 48.39% -16.96%
=============================================
Files 1208 109 -1099
Lines 69969 10493 -59476
Branches 1280 1280
=============================================
- Hits 45726 5078 -40648
+ Misses 23871 5043 -18828
Partials 372 372
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #34865 +/- ##
=============================================
- Coverage 65.35% 48.39% -16.96%
=============================================
Files 1208 109 -1099
Lines 69969 10493 -59476
Branches 1280 1280
=============================================
- Hits 45727 5078 -40649
+ Misses 23870 5043 -18827
Partials 372 372
Continue to review full report at Codecov.
|
91b59d0 to
1767841
Compare
1767841 to
3f92b1f
Compare
|
Sadly issue #34858 is not solved by PHPUnit6. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly, we get the same outcome with PHPUnit6:
https://drone.owncloud.com/owncloud/core/16424/199
runs 9609 unit tests with sqlite and PHP7.1 - it correctly sees 6 failures and exits with error - good.
https://drone.owncloud.com/owncloud/core/16424/207
runs 9609 unit tests with sqlite and PHP7.2 - it correctly sees 6 failures but exits with success status - bad.
https://drone.owncloud.com/owncloud/core/16424/224
runs 9609 unit tests with sqlite and PHP7.3 - it correctly sees 6 failures but exits with success status - bad.
This is the same observed behavior as with PHPUnit5 :(
We need to bump up to PHPUnit6 anyway, but I was also hoping that it would resolve this "exit status" issue.