Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acceptance tests for exclusive locks #34359

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Feb 1, 2019

Description

test to check if exclusive locks are enforced correctly

Related Issue

Motivation and Context

more tests

How Has This Been Tested?

🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

| new | exclusive |

@issue-34358
Scenario Outline: if a child ressource is exclusivly locked a parrent ressource cannot be locked again
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Scenario Outline: if a child ressource is exclusivly locked a parrent ressource cannot be locked again
Scenario Outline: if a child ressource is exclusivly locked a parent resource cannot be locked again

| new | shared |
| new | exclusive |

Scenario Outline: if a child ressource is exclusivly locked a parrent ressource can be locked with depth 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Scenario Outline: if a child ressource is exclusivly locked a parrent ressource can be locked with depth 0
Scenario Outline: if a child ressource is exclusivly locked a parent resource can be locked with depth 0

@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #34359 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34359   +/-   ##
=========================================
  Coverage     64.77%   64.77%           
  Complexity    18370    18370           
=========================================
  Files          1199     1199           
  Lines         69554    69554           
  Branches       1281     1281           
=========================================
  Hits          45054    45054           
  Misses        24127    24127           
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.12% <ø> (ø) 18370 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c81dd05...adca148. Read the comment docs.

@individual-it
Copy link
Member Author

@dpakach fixed typos

Background:
Given user "user0" has been created with default attributes

Scenario Outline: a second lock cannot be set on a folder when its exclusivly locked
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYPO: exclusively

| new | shared |
| new | exclusive |

Scenario Outline: if a parent ressource is exclusivly locked a child ressource cannot be locked again
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYPO: exclusively

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYPO: resource

@individual-it
Copy link
Member Author

@davitol fixed typos

@davitol davitol self-requested a review February 1, 2019 11:34
Copy link
Contributor

@davitol davitol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@individual-it
Copy link
Member Author

backport in #34363

@lock lock bot locked as resolved and limited conversation to collaborators Feb 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api acceptance tests for exclusive locks
3 participants