-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove default is plain from occ command help #33169
Conversation
Codecov Report
@@ Coverage Diff @@
## master #33169 +/- ##
=========================================
Coverage 64.12% 64.12%
Complexity 18720 18720
=========================================
Files 1184 1184
Lines 70437 70437
Branches 1270 1270
=========================================
Hits 45171 45171
Misses 24896 24896
Partials 370 370
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@PVince81 for some occ commands the default output is JSON, so this hardcoded default is plain
makes confusion. Please review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
backport ? |
Backport |
Description
This PR removes the
default is plain
message from occ command help.Related issue: #33168
After removing the text, the help message looks like this:
