Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default is plain from occ command help #33169

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

paurakhsharma
Copy link
Member

Description

This PR removes the default is plain message from occ command help.
Related issue: #33168

After removing the text, the help message looks like this:
image

@codecov
Copy link

codecov bot commented Oct 12, 2018

Codecov Report

Merging #33169 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33169   +/-   ##
=========================================
  Coverage     64.12%   64.12%           
  Complexity    18720    18720           
=========================================
  Files          1184     1184           
  Lines         70437    70437           
  Branches       1270     1270           
=========================================
  Hits          45171    45171           
  Misses        24896    24896           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.89% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.4% <100%> (ø) 18720 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
core/Command/Base.php 83.6% <100%> (ø) 23 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b054dd5...f33c91c. Read the comment docs.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@PVince81 for some occ commands the default output is JSON, so this hardcoded default is plain makes confusion. Please review.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 46efb61 into master Oct 12, 2018
@PVince81 PVince81 deleted the remove-default-is-plain-from-occ branch October 12, 2018 13:19
@PVince81
Copy link
Contributor

backport ?

@phil-davis
Copy link
Contributor

Backport stable10 #33179

@davitol davitol mentioned this pull request Jan 2, 2019
39 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants