API test to check that share can be made with file names more than 64 chars long #33009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backport on: #33010 |
phil-davis
requested changes
Oct 4, 2018
| When user "user0" shares file "aquickbrownfoxjumpsoveraverylazydogaquickbrownfoxjumpsoveralazydog.txt" with user "user1" using the sharing API | ||
| Then the OCS status code should be "<ocs_status_code>" | ||
| And the HTTP status code should be "200" | ||
| And the share fields of the last share should include |
There was a problem hiding this comment.
Also check that user1 can access the file
| When user "user0" shares file "aquickbrownfoxjumpsoveraverylazydogaquickbrownfoxjumpsoveralazydog.txt" with group "grp1" using the sharing API | ||
| Then the OCS status code should be "<ocs_status_code>" | ||
| And the HTTP status code should be "200" | ||
| And the share fields of the last share should include |
There was a problem hiding this comment.
create user1, put them in grp1, and make sure they can access the file
| | 1 | 100 | | ||
| | 2 | 200 | | ||
|
|
||
| Scenario Outline: user create a public link share of a file with file name longer than 64 chars |
| | 1 | 100 | | ||
| | 2 | 200 | | ||
|
|
||
| Scenario Outline: user create a public link share of a folder with folder name longer than 64 chars |
| | path | /aquickbrownfoxjumpsoveraverylazydogaquickbrownfoxjumpsoveralazydog | | ||
| Then the OCS status code should be "<ocs_status_code>" | ||
| And the HTTP status code should be "200" | ||
| And the share fields of the last share should include |
There was a problem hiding this comment.
put a file in the folder, and check that the public can access the file
Codecov Report
@@ Coverage Diff @@
## master #33009 +/- ##
=========================================
Coverage 64.14% 64.14%
Complexity 18721 18721
=========================================
Files 1185 1185
Lines 70454 70454
Branches 1270 1270
=========================================
Hits 45195 45195
Misses 24889 24889
Partials 370 370
Continue to review full report at Codecov.
|
a76b274 to
bca48a2
Compare
phil-davis
approved these changes
Oct 4, 2018
bca48a2 to
6def591
Compare
6def591 to
4be3530
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tests for sharing of files and folders with name longer than 64 characters
Related issue: #32763
How Has This Been Tested?
Locally
Types of changes
Checklist: