-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escapre urlencoding of strings to allow them read properly #32628
Conversation
Escape urlencoding of strings to make them read properly. Signed-off-by: Sujith H <sharidasan@owncloud.com>
Codecov Report
@@ Coverage Diff @@
## master #32628 +/- ##
=========================================
Coverage 64.14% 64.14%
Complexity 18681 18681
=========================================
Files 1177 1177
Lines 70283 70283
Branches 1270 1270
=========================================
Hits 45085 45085
Misses 24828 24828
Partials 370 370
Continue to review full report at Codecov.
|
Was the text doubly escaped ? Is the test " ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
just to be sure I retested with tags in the name like test<b>bc<br>
and they were properly displayed
please backport |
Backport PR #33419 |
Escape urlencoding of strings to make them read properly.
Signed-off-by: Sujith H sharidasan@owncloud.com
Description
Show the strings like share link file name and custom groups with special characters display without urlencoding.
Related Issue
Motivation and Context
Show the strings like share link file name and custom groups with special characters display without urlencoding.
How Has This Been Tested?
a'b
Link name
text box should displaya'b link
instead of encoded texta'b
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: