Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escapre urlencoding of strings to allow them read properly #32628

Merged
merged 1 commit into from
Sep 27, 2018

Conversation

sharidas
Copy link
Contributor

@sharidas sharidas commented Sep 7, 2018

Escape urlencoding of strings to make them read properly.

Signed-off-by: Sujith H sharidasan@owncloud.com

Description

Show the strings like share link file name and custom groups with special characters display without urlencoding.

Related Issue

  • Fixes <issue_link>

Motivation and Context

Show the strings like share link file name and custom groups with special characters display without urlencoding.

How Has This Been Tested?

  • Create a folder with a'b
  • Launch the public link dialog window the Link name text box should display a'b link instead of encoded text
  • Create a custom group with a'b
  • Try to share a file or folder with the group, the suggestion should show the group name properly.

Screenshots (if appropriate):

  • public link
    publink
  • group name
    group

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

Escape urlencoding of strings to make them read properly.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
@sharidas sharidas self-assigned this Sep 7, 2018
@sharidas sharidas added this to the development milestone Sep 7, 2018
@sharidas sharidas requested a review from PVince81 September 7, 2018 06:58
@codecov
Copy link

codecov bot commented Sep 7, 2018

Codecov Report

Merging #32628 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #32628   +/-   ##
=========================================
  Coverage     64.14%   64.14%           
  Complexity    18681    18681           
=========================================
  Files          1177     1177           
  Lines         70283    70283           
  Branches       1270     1270           
=========================================
  Hits          45085    45085           
  Misses        24828    24828           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.89% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.42% <ø> (ø) 18681 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
core/js/sharedialogview.js 78.78% <ø> (ø) 0 <0> (ø) ⬇️
core/js/sharedialoglinklistview.js 62.85% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2551ab...ef8f94a. Read the comment docs.

@PVince81
Copy link
Contributor

PVince81 commented Sep 7, 2018

Was the text doubly escaped ?

Is the text value being escaped again still at display time ? You can test by having a group/text be "

test
" ...

@sharidas
Copy link
Contributor Author

sharidas commented Sep 7, 2018

Was the text doubly escaped ?
Is the text value being escaped again still at display time ? You can test by having a group/text be "
test
" ...

With double quotes I get the result as
withdoublequotes

guess this looks fine.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

just to be sure I retested with tags in the name like test<b>bc<br> and they were properly displayed

@PVince81 PVince81 merged commit 6e2d041 into master Sep 27, 2018
@PVince81 PVince81 deleted the escape-urlencode branch September 27, 2018 12:40
@PVince81
Copy link
Contributor

please backport

@sharidas
Copy link
Contributor Author

sharidas commented Nov 5, 2018

Backport PR #33419

@lock lock bot locked as resolved and limited conversation to collaborators Nov 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants