Prevent LDAP Password to appear in log file

[voroyam]

If connection to LDAP server is lost, the LDAP password is shown in the stack trace.

This should prevent this from happening.

[CLAassistant]

All committers have signed the CLA.

[cdamken]

@tomneedham @PVince81 @butonic Could you please review this?

[PVince81]

these comments look useless...

[voroyam]

They are, any suggestions how to improve them?

[PVince81]

no need to improve now

I was just pointing at the fact that the comment is exactly the same as the string itself, so doesn't have much value.

doesn't matter now, let's merge when CI is green

[PVince81]

👍

[PVince81]

@voroyam please backport to stable10

[voroyam]

@PVince81 don't know how to backport, already told @tom this.

[PVince81]

stable10: #32592

[PVince81]

rebased

[codecov]

Codecov Report

Merging #32589 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #32589      +/-   ##
============================================
+ Coverage     64.14%   64.21%   +0.07%     
- Complexity    18672    18727      +55     
============================================
  Files          1177     1177              
  Lines         70275    70499     +224     
  Branches       1270     1270              
============================================
+ Hits          45076    45273     +197     
- Misses        24829    24856      +27     
  Partials        370      370

Flag	Coverage Δ	Complexity Δ
#javascript	52.89% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	65.5% <ø> (+0.07%)	18727 <ø> (+55)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Log.php	82.53% <ø> (ø)	49 <0> (ø)	⬇️
lib/private/User/Database.php	73.23% <0%> (+1.19%)	61% <0%> (+18%)	⬆️
lib/private/User/User.php	89.93% <0%> (+1.76%)	103% <0%> (+31%)	⬆️
lib/public/Util.php	63.88% <0%> (+6.82%)	83% <0%> (+6%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ce6bde...21f0c99. Read the comment docs.

[patrickjahns]

Regarding the comments about useless string - suggestion, mention that the two methods bind // invokeLDAPMethod result from user_ldap.

// user_ldap app 
'bind'
'invokeLDAPMethod'