Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overriding for gif images in themes for CLI scripts #31990

Merged
merged 2 commits into from
Jul 23, 2018
Merged

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Jul 4, 2018

Description

Related Issue

Motivation and Context

Fixes overriding logo for emails that are sent from CLI

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@VicDeo VicDeo added this to the development milestone Jul 4, 2018
@VicDeo VicDeo self-assigned this Jul 4, 2018
@codecov
Copy link

codecov bot commented Jul 6, 2018

Codecov Report

Merging #31990 into master will increase coverage by 0.31%.
The diff coverage is 73.91%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #31990      +/-   ##
============================================
+ Coverage     63.51%   63.83%   +0.31%     
  Complexity    18554    18554              
============================================
  Files          1169     1169              
  Lines         69719    69727       +8     
  Branches       1264     1264              
============================================
+ Hits          44285    44511     +226     
+ Misses        25065    24847     -218     
  Partials        369      369
Flag Coverage Δ Complexity Δ
#javascript 52.59% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.12% <73.91%> (+0.35%) 18554 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/base.php 5.91% <ø> (ø) 126 <0> (ø) ⬇️
lib/private/Server.php 86.37% <100%> (+0.01%) 253 <0> (ø) ⬇️
lib/private/URLGenerator.php 89.02% <71.42%> (-2.98%) 35 <0> (ø)
lib/private/Helper/EnvironmentHelper.php 66.66% <0%> (+33.33%) 3% <0%> (ø) ⬇️
apps/files_external/lib/Lib/Storage/Swift.php 66.16% <0%> (+66.16%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b161b20...17f41bc. Read the comment docs.

@VicDeo VicDeo changed the title Fix overriding for gif images in themes Fix overriding for gif images in themes for CLI scripts Jul 6, 2018
@VicDeo VicDeo requested a review from PVince81 July 9, 2018 15:45
@PVince81 PVince81 requested review from butonic and DeepDiver1975 July 9, 2018 15:50
@VicDeo
Copy link
Member Author

VicDeo commented Jul 18, 2018

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and makes sense 👍

@PVince81 PVince81 merged commit 3f14d20 into master Jul 23, 2018
@PVince81 PVince81 deleted the fix-31804 branch July 23, 2018 15:26
@PVince81
Copy link
Contributor

@VicDeo please backport

@VicDeo
Copy link
Member Author

VicDeo commented Jul 23, 2018

stable10: #32131

@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theming: overriding is broken for gif images
4 participants