Fix apiVersion type and createShare call parameters

[phil-davis]

Description

1. Fix call parameters for createShare
2. Cast the apiVersion to ``int``` when storing it.

Related Issue

Motivation and Context

createShare() has a missing parameter in the call - fix it.
When we fix it, and/or make use of createAPublicShare() then SharingHelper::createShare() complains about "invalid apiVersion/sharingApiVersion" because it now gets apiVersion in the correct parameter. apiVersion is suppposed to be an int.

How Has This Been Tested?

Local API acceptance test runs.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Acceptance test bug fix

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[phil-davis]

We might not have been using the API version we thought we were using, when creating shares. So some tests that create and do stuff with shares might now misbehave.

[paurakhsharma]

I don't think any sharing tests user API version 2 so it should all pass. Let's see what CI says.

[phil-davis]

Backport stable10 #31679

[codecov]

Codecov Report

Merging #31677 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #31677   +/-   ##
=========================================
  Coverage     62.89%   62.89%           
  Complexity    18418    18418           
=========================================
  Files          1154     1154           
  Lines         69157    69157           
  Branches       1260     1260           
=========================================
  Hits          43499    43499           
  Misses        25289    25289           
  Partials        369      369

Flag	Coverage Δ	Complexity Δ
#javascript	52.39% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	64.1% <ø> (ø)	18418 <ø> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 031fded...92879f1. Read the comment docs.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.