-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reresubmit: improved persistent cookies :) #31
Conversation
switched from time() to internal method OC_Util::generate_random_bytes()
outdated tokens are deleted before checking against cookies if an invalid token is used we delete all stored tokens for saveness used token will be replaced by a new one after successful authentication
Hi Michael, it seems to me your generating a 1024 bit key now:
Greetings |
Well, this is probably my fault because the description is not very accurate. Let's rename this function to From a security point of view this should be safe to merge and together with #30 this is a real improvement. +1 from me. |
No Lukas, the method name is fine. It was my fault. I mixed up bits and bytes. As 128byte is no performance problem, we use 256bit / 32byte now. Which is equal to a md5 hash or a PHPSESSID. Regards, |
reresubmit: improved persistent cookies :)
Let's merge it - Thanks! |
…emes Fix 30 for enterprise themes
After some review rounds with @scroogie I decided to put this into a merge request again.
I used @bartv2's draft and implemented all our comments (from pull request #26).
Here a short summary of the new features:
Please review and comment!