Fix multiple CI failures on master

[PVince81]

Fixes errors that sneaked it while CI was not looking

[VicDeo]

Thanks!

[codecov]

Codecov Report

Merging #30992 into master will increase coverage by 0.15%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #30992      +/-   ##
============================================
+ Coverage     62.16%   62.31%   +0.15%     
  Complexity    18208    18208              
============================================
  Files          1142     1142              
  Lines         68190    68190              
  Branches       1232     1232              
============================================
+ Hits          42391    42494     +103     
+ Misses        25438    25335     -103     
  Partials        361      361

Flag	Coverage Δ	Complexity Δ
#javascript	52.04% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	63.48% <ø> (+0.16%)	18208 <ø> (ø)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
lib/public/Util/UserSearch.php	100% <ø> (ø)	4 <0> (ø)	⬇️
lib/private/Files/View.php	84.46% <0%> (+0.3%)	383% <0%> (ø)	⬇️
lib/private/Repair/RepairMismatchFileCachePath.php	85.2% <0%> (+0.4%)	49% <0%> (ø)	⬇️
lib/private/DB/QueryBuilder/QueryBuilder.php	91.66% <0%> (+0.46%)	68% <0%> (ø)	⬇️
lib/private/DB/MDB2SchemaManager.php	91.22% <0%> (+1.75%)	17% <0%> (ø)	⬇️
lib/private/DB/Connection.php	68.38% <0%> (+4.41%)	49% <0%> (ø)	⬇️
...private/DB/MySqlSchemaColumnDefinitionListener.php	5.4% <0%> (+5.4%)	46% <0%> (ø)	⬇️
lib/private/DB/MDB2SchemaWriter.php	93.75% <0%> (+6.25%)	34% <0%> (ø)	⬇️
lib/private/DB/ConnectionFactory.php	82.89% <0%> (+9.21%)	21% <0%> (ø)	⬇️
lib/private/DB/AdapterMySQL.php	50% <0%> (+50%)	4% <0%> (ø)	⬇️
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c59a9d1...21c1922. Read the comment docs.

[PVince81]

still fails, now with Oracle... might still be a random thing

[phil-davis]

It is going to be:
https://github.com/owncloud/core/blob/master/tests/lib/Repair/RepairOrphanedSubshareTest.php#L255
when choosing 20 rows to "randomly" delete, then sometimes it can choose the same row twice. Then it actually only deletes 19 rows. So the count of remaining rows ends up 1 larger than expected.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.