Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI tests to add public link shares to remote server #29860

Merged
merged 1 commit into from
Dec 19, 2017
Merged

UI tests to add public link shares to remote server #29860

merged 1 commit into from
Dec 19, 2017

Conversation

individual-it
Copy link
Member

UI tests for #29675

@individual-it individual-it added this to the development milestone Dec 15, 2017
@individual-it individual-it self-assigned this Dec 15, 2017
@individual-it individual-it mentioned this pull request Dec 15, 2017
Merged
@codecov
Copy link

codecov bot commented Dec 15, 2017 •
edited
Loading

Codecov Report

Merging #29860 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #29860   +/-   ##
=========================================
  Coverage     58.17%   58.17%           
  Complexity    18457    18457           
=========================================
  Files          1092     1092           
  Lines         63617    63617           
=========================================
  Hits          37012    37012           
  Misses        26605    26605

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b1eee2...3a07716. Read the comment docs.

@individual-it
Copy link
Member Author

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost!

@ownclouders
Copy link
Contributor

Automated rebase was successful!

@ownclouders ownclouders force-pushed the ui-tests-imp-fed-shares branch from 532e3cc to b4be908 Compare December 18, 2017 03:22
@individual-it individual-it force-pushed the ui-tests-imp-fed-shares branch from b4be908 to f60d5ca Compare December 19, 2017 06:30
@individual-it individual-it force-pushed the ui-tests-imp-fed-shares branch from f60d5ca to 3a07716 Compare December 19, 2017 06:37
@individual-it
Copy link
Member Author

@phil-davis had to do some changes, please review again

phil-davis
phil-davis approved these changes Dec 19, 2017
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@individual-it individual-it merged commit ad64900 into master Dec 19, 2017
@individual-it individual-it deleted the ui-tests-imp-fed-shares branch December 19, 2017 08:37
@individual-it individual-it mentioned this pull request Dec 19, 2017
Closed
@phil-davis
Copy link
Contributor

Backport stable10 #29863

@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@tomneedham tomneedham Awaiting requested review from tomneedham

Assignees

@individual-it individual-it

Labels
3 - To Review dev:acceptance-tests
Projects
None yet
Milestone
10.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@individual-it @ownclouders @phil-davis