Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Sort allowed storages checkbox list #29746

Merged
merged 1 commit into from
Dec 2, 2017

Conversation

phil-davis
Copy link
Contributor

Backport #29733

@phil-davis phil-davis added this to the development milestone Dec 1, 2017
@phil-davis phil-davis self-assigned this Dec 1, 2017
@phil-davis phil-davis changed the title Sort allowed storages checkbox list [stable10] Sort allowed storages checkbox list Dec 1, 2017
@codecov
Copy link

codecov bot commented Dec 1, 2017

Codecov Report

Merging #29746 into stable10 will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #29746      +/-   ##
==============================================
+ Coverage       60.72%   60.74%   +0.01%     
- Complexity      17879    17943      +64     
==============================================
  Files            1064     1064              
  Lines           59504    59763     +259     
==============================================
+ Hits            36136    36304     +168     
- Misses          23368    23459      +91
Impacted Files Coverage Δ Complexity Δ
...ib/private/DB/QueryBuilder/CompositeExpression.php 50% <0%> (-12.5%) 6% <0%> (+3%)
lib/autoloader.php 79.62% <0%> (-2.38%) 27% <0%> (+2%)
lib/private/Log/ErrorHandler.php 6.45% <0%> (-1.55%) 12% <0%> (ø)
lib/private/Route/Router.php 53.12% <0%> (-1.43%) 54% <0%> (+7%)
apps/encryption/lib/Util.php 30% <0%> (-1.38%) 13% <0%> (-3%)
apps/dav/lib/CalDAV/Calendar.php 84.11% <0%> (-0.85%) 43% <0%> (-4%)
lib/private/URLGenerator.php 89.04% <0%> (-0.79%) 34% <0%> (+1%)
apps/dav/lib/DAV/Sharing/Plugin.php 67.56% <0%> (-0.73%) 14% <0%> (ø)
lib/private/Files/Node/File.php 92.59% <0%> (-0.14%) 25% <0%> (ø)
lib/private/Mail/Mailer.php 67.64% <0%> (-0.05%) 21% <0%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab7e64a...4104daa. Read the comment docs.

@mmattel mmattel merged commit bb94b91 into stable10 Dec 2, 2017
@mmattel mmattel deleted the stable10-sort-allowed-storages-checkbox-list branch December 2, 2017 12:57
@ghost
Copy link

ghost commented Dec 2, 2017

Fixes #29732 for stable10

@phil-davis
Copy link
Contributor Author

@PVince81 this has been merged to stable10 while the v10.0.4RC2 tag is still waiting to happen.
What to do?
Feel free to revert if you wish.

@PVince81
Copy link
Contributor

PVince81 commented Dec 3, 2017

@mmattel please don't merge non-critical fixes to stable10 as we're still post RC and want to keep it stable.

I'm fine keeping it as it's low risk but we'll have QA double check

@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants