Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI tests for upload feature #29573

Merged
merged 1 commit into from
Nov 15, 2017
Merged

UI tests for upload feature #29573

merged 1 commit into from
Nov 15, 2017

Conversation

individual-it
Copy link
Member

Description

UI tests that check the basic upload feature

Related Issue

owncloud/QA#437

Motivation and Context

  • the upload tests are split into 2 feature files. One for general uploads one for edge cases. That is because we want to test edge cases but if developers or management is reading the feature files (BDD) they don't need to be bored by reading the edge cases
  • other tests are touched because of renaming a file in the skeleton folder
  • the files to upload have partly the same names like the files in the skeleton but different content to test overwriting

How Has This Been Tested?

run locally, run on travis

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@individual-it
Copy link
Member Author

backport in #29574

@codecov
Copy link

codecov bot commented Nov 15, 2017

Codecov Report

Merging #29573 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #29573   +/-   ##
=========================================
  Coverage     61.71%   61.71%           
  Complexity    17482    17482           
=========================================
  Files          1047     1047           
  Lines         57714    57714           
=========================================
  Hits          35619    35619           
  Misses        22095    22095

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75e6bd7...754035c. Read the comment docs.

@phil-davis phil-davis merged commit bbdc0fc into master Nov 15, 2017
@phil-davis phil-davis deleted the ui-tests-upload branch November 15, 2017 06:10
phil-davis added a commit to owncloud/QA that referenced this pull request Nov 16, 2017
individual-it pushed a commit to owncloud/QA that referenced this pull request Nov 16, 2017
@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants