Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

From [stable10] missing non browser auth token #29533

Merged
merged 2 commits into from
Nov 13, 2017
Merged

From [stable10] missing non browser auth token #29533

merged 2 commits into from
Nov 13, 2017

Conversation

IljaN
Copy link
Contributor

@IljaN IljaN commented Nov 10, 2017

Forward port of #28879

fixes #27845
fixes #28553
fixes #28881

IljaN added 2 commits November 10, 2017 15:06
@IljaN
Fixing missing oc_authtoken for native clients #27845
2ac87e4 
Current token must be not null

Generate auth token for http_basic_auth logins

Cleanup

(cherry picked from commit 03b0bdb)
@IljaN
Better code formating
23c3e00 
(cherry picked from commit de3597a)
@IljaN IljaN requested a review from PVince81 November 10, 2017 14:10
@IljaN IljaN changed the title Forward port missing non browser auth token From [stable10] missing non browser auth token Nov 10, 2017
@IljaN IljaN self-assigned this Nov 10, 2017
@codecov
Copy link

codecov bot commented Nov 10, 2017 •
edited
Loading

Codecov Report

Merging #29533 into master will decrease coverage by 0.01%.
The diff coverage is 12.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #29533      +/-   ##
============================================
- Coverage     61.39%   61.37%   -0.02%     
- Complexity    17472    17477       +5     
============================================
  Files          1044     1044              
  Lines         57695    57710      +15     
============================================
+ Hits          35419    35421       +2     
- Misses        22276    22289      +13
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/app.php 58.44% <0%> (-1.4%) 201 <0> (+3)
settings/Controller/AuthSettingsController.php 86.44% <66.66%> (-1.06%) 19 <0> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dba2ed...23c3e00. Read the comment docs.

PVince81
PVince81 approved these changes Nov 10, 2017
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added this to the development milestone Nov 10, 2017
@PVince81 PVince81 merged commit 517df62 into master Nov 13, 2017
@PVince81 PVince81 deleted the forward_port_missing_non_browser_auth_token branch November 13, 2017 09:36
@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PVince81 PVince81 PVince81 approved these changes

Assignees

@IljaN IljaN

Labels
4 - To release status/STALE
Projects
None yet
Milestone
10.0.5
3 participants
@IljaN @PVince81 @ownclouders