Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating mysql php 7.0 job from jenkins to drone #29409

Merged
merged 1 commit into from
Nov 3, 2017

Conversation

SergioBertolinSG
Copy link
Contributor

No description provided.

# DB_TYPE: mysql
# TEST_SUITE: phpunit
- PHP_VERSION: 7.0
DB_TYPE: mysql
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which mysql version is used on drone? we have to be care full to choose an older version which does not automatically enable mb4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.7

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jenkins is currently running 5.5 - 5.7 is the version to be used with mb4 ...
https://github.com/owncloud/core/blob/master/build/autotest.sh#L228

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also incorporate these settings in the server - this will give us faster execution times - https://github.com/owncloud/core/blob/master/tests/docker/mariadb/oc.cnf

but lets first see how long it takes without

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, should I migrate the mb4 stage in this PR as well or in a different one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mb4 into a pr of its own please

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX

@codecov
Copy link

codecov bot commented Nov 2, 2017

Codecov Report

Merging #29409 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #29409      +/-   ##
============================================
+ Coverage     60.52%    60.7%   +0.18%     
+ Complexity    17198    17193       -5     
============================================
  Files          1031     1031              
  Lines         57298    57290       -8     
============================================
+ Hits          34677    34780     +103     
+ Misses        22621    22510     -111
Impacted Files Coverage Δ Complexity Δ
lib/private/Repair/SqliteAutoincrement.php 85.18% <0%> (-3.28%) 9% <0%> (ø)
lib/private/DB/AdapterSqlite.php 83.33% <0%> (-2.88%) 7% <0%> (ø)
apps/dav/lib/DAV/FileCustomPropertiesBackend.php 90.9% <0%> (-0.96%) 18% <0%> (-5%)
apps/dav/lib/Connector/Sabre/FilesPlugin.php 85.71% <0%> (-0.1%) 45% <0%> (ø)
lib/private/Files/View.php 84.45% <0%> (+0.31%) 370% <0%> (ø) ⬇️
lib/private/Repair/RepairMismatchFileCachePath.php 82.52% <0%> (+0.4%) 48% <0%> (ø) ⬇️
lib/private/DB/QueryBuilder/QueryBuilder.php 90.68% <0%> (+0.49%) 67% <0%> (ø) ⬇️
lib/private/DB/Connection.php 67.44% <0%> (+1.55%) 45% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaManager.php 85.96% <0%> (+5.26%) 17% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaWriter.php 92.7% <0%> (+6.25%) 34% <0%> (ø) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a48a2a...289438c. Read the comment docs.

@SergioBertolinSG SergioBertolinSG force-pushed the drone-enabling-phpunit-mysql branch from eb767b7 to 8fd6cb8 Compare November 2, 2017 09:37
@DeepDiver1975 DeepDiver1975 added this to the development milestone Nov 2, 2017
MySQL version should be 5.5 to not be able to handle mb4
@SergioBertolinSG SergioBertolinSG force-pushed the drone-enabling-phpunit-mysql branch from 8fd6cb8 to 289438c Compare November 3, 2017 07:58
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants