-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating mysql php 7.0 job from jenkins to drone #29409
Conversation
# DB_TYPE: mysql | ||
# TEST_SUITE: phpunit | ||
- PHP_VERSION: 7.0 | ||
DB_TYPE: mysql |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which mysql version is used on drone? we have to be care full to choose an older version which does not automatically enable mb4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5.7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jenkins is currently running 5.5 - 5.7 is the version to be used with mb4 ...
https://github.com/owncloud/core/blob/master/build/autotest.sh#L228
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also incorporate these settings in the server - this will give us faster execution times - https://github.com/owncloud/core/blob/master/tests/docker/mariadb/oc.cnf
but lets first see how long it takes without
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, should I migrate the mb4 stage in this PR as well or in a different one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mb4 into a pr of its own please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THX
Codecov Report
@@ Coverage Diff @@
## master #29409 +/- ##
============================================
+ Coverage 60.52% 60.7% +0.18%
+ Complexity 17198 17193 -5
============================================
Files 1031 1031
Lines 57298 57290 -8
============================================
+ Hits 34677 34780 +103
+ Misses 22621 22510 -111
Continue to review full report at Codecov.
|
eb767b7
to
8fd6cb8
Compare
MySQL version should be 5.5 to not be able to handle mb4
8fd6cb8
to
289438c
Compare
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.