Use chunks of 999 when preload directory content #29405
Conversation
653e37c to
a5ea1d2
Compare
Codecov Report
@@ Coverage Diff @@
## master #29405 +/- ##
============================================
+ Coverage 60.51% 60.51% +<.01%
- Complexity 17193 17198 +5
============================================
Files 1031 1031
Lines 57288 57297 +9
============================================
+ Hits 34667 34676 +9
Misses 22621 22621
Continue to review full report at Codecov.
|
| */ | ||
| private function getChunks($toSlice, $otherPlaceholdersCount = 0) { | ||
| $databasePlatform = $this->connection->getDatabasePlatform(); | ||
| if ($databasePlatform instanceof OraclePlatform || $databasePlatform instanceof SqlitePlatform) { |
There was a problem hiding this comment.
In the past I think I'd say let's do the workaround for all DBs to avoid hard-coding the names. But after all this time I'm wondering: why impair the performance of the other DBs just because these two ?
And the code as you wrote it is better than just having a PHPDoc saying "workaround for XYZ", so let's keep it.
|
Stable10: #29416 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Use chunks of 999 when preload directory content
Related Issue
#29233
Motivation and Context
999 placeholder limit in Sqlite/Oracle
How Has This Been Tested?
With a unit test
Types of changes
Checklist: