Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not translate CORS header in settings page #29307

Merged
merged 1 commit into from
Oct 20, 2017

Conversation

kraigh
Copy link
Contributor

@kraigh kraigh commented Oct 19, 2017

Description

Do not translate CORS heading on settings page

Related Issue

Fixes #29298

Motivation and Context

CORS is translated inappropriately, and being a technical term probably does not require translation.

How Has This Been Tested?

Just a content change. Not sure how to write a test in this case.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2017

CLA assistant check
All committers have signed the CLA.

@DeepDiver1975 DeepDiver1975 self-requested a review October 20, 2017 03:53
@DeepDiver1975 DeepDiver1975 self-assigned this Oct 20, 2017
@DeepDiver1975 DeepDiver1975 added this to the development milestone Oct 20, 2017
Copy link
Member

@DeepDiver1975 DeepDiver1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thx

@individual-it
Copy link
Member

UI tests fail here because the PR comes from a remote fork, so travis cannot access the saucelabs credentials.
But this change should not break any tests, so I would suggest to merge it even without the green travis tick.

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Personal settings: CORS should not be translated
5 participants