check trashbin after deletion in UI tests #28990
Conversation
tests/ui/features/lib/FilesPage.php
Outdated
| $this->getDriver()->getCurrentUrl() | ||
| ) | ||
| ); | ||
| throw new UnexpectedPageException( |
There was a problem hiding this comment.
Somehow this block got a bonus indent. Not important but can be fixed since you will have to fix the other comment.
There was a problem hiding this comment.
wondering why the pre commit hook did not shout at me
| * @return void | ||
| */ | ||
| public function openFile($name, Session $session) { | ||
| $fileRow = $this->findFileRowByNaBasicme($name, $session); |
There was a problem hiding this comment.
This does not look so good findFileRowByNaBasicme ?
There was a problem hiding this comment.
CI failed because of that, fixed now
10d09cf to
44543b9
Compare
|
Note: files_texteditor UI tests pass on top of this. So |
|
backport to stable10 in #28995 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
when deleting files in the test the trashbin should be checked to see if it works correctly
Related Issue
owncloud/QA#437
Motivation and Context
more tests leads to less bugs
The Simplified Smoke Test requires to check the trashbin
How Has This Been Tested?
run tests locally
Screenshots (if appropriate):
Types of changes
Checklist: