Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Fix error logs due to deletion of keys #28934

Merged

Conversation

sharidas
Copy link
Contributor

@sharidas sharidas commented Sep 7, 2017

When files are deleted and moved to trashbin,
the keys are deleted. This results in exception
due to file not exist. And hence this change
helps to fix the issue. The issue is caused
when the version of the files are tried to
retain in the trashbin.

Signed-off-by: Sujith H sharidasan@owncloud.com

Description

When the files are moved to trashbin, the retain version causes problem. Which means the retainVersion in the trashbin tries to access the file keys which are already deleted. So this causes exception.

Related Issue

#28883

Motivation and Context

This change tries to solve the issue caused by accessing file keys which are already deleted during the transfer of files to trashbin.

How Has This Been Tested?

  • Enable encryption with master key
  • Enable external sotrage with SFTP
  • Upload a file to SFTP folder
  • Update the file.
  • Delete the file . The log file is clean and no exceptions.
  • Restore the file. The log file is clean and no exceptions.
  • Download the versions of the file.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

When files are deleted and moved to trashbin,
the keys are deleted. This results in exception
due to file not exist. And hence this change
helps to fix the issue. The issue is caused
when the version of the files are tried to
retain in the trashbin.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
@sharidas sharidas added this to the planned milestone Sep 7, 2017
@sharidas sharidas self-assigned this Sep 7, 2017
@sharidas sharidas requested a review from PVince81 September 7, 2017 05:24
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to merge for 10.0.4

@PVince81 PVince81 merged commit d72ce16 into stable10 Sep 18, 2017
@PVince81 PVince81 deleted the fix-errorlogs-encryptionwrapper-trashbin-stable10 branch September 18, 2017 12:22
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants