Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new DAV endpoint in web UI #28874

Merged
merged 2 commits into from
Feb 13, 2018
Merged

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Aug 31, 2017

Description

Use new DAV endpoint for everything, including single file uploads

Related Issue

None.
Also see #25494

Motivation and Context

Same as #25494

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Not sure if we want this right now, I'm thinking of reverting new dav for 10.0.3 due to #28779.

Setting to "planned" to have a look later.

@PVince81 PVince81 added this to the planned milestone Aug 31, 2017
@PVince81 PVince81 self-assigned this Aug 31, 2017
@PVince81 PVince81 requested a review from jvillafanez August 31, 2017 13:48
@PVince81 PVince81 changed the title Use new DAV endpoint for single file uploads Use new DAV endpoint in web UI Sep 7, 2017
@PVince81 PVince81 force-pushed the filelist-upload-usenewdav branch from c4508cd to 5260698 Compare September 7, 2017 08:33
@jvillafanez
Copy link
Member

jvillafanez commented Oct 20, 2017

From #29315 (comment)

  • reuploading a file to an external storage causes an "undefined index: size" in the logs (not tested with the primary storage). Checked with 10.0.3. Not that the first time the file is uploaded, such log doesn't appear.

@PVince81
Copy link
Contributor Author

@jvillafanez undefined size like this issue: #29246

@PVince81 PVince81 modified the milestones: development, planned Nov 6, 2017
@PVince81 PVince81 modified the milestones: planned, development Nov 22, 2017
@PVince81 PVince81 force-pushed the filelist-upload-usenewdav branch from 5260698 to bc7549a Compare December 18, 2017 11:38
@PVince81
Copy link
Contributor Author

#28853 was merged, we can move forward with this. @DeepDiver1975

@codecov
Copy link

codecov bot commented Dec 18, 2017

Codecov Report

Merging #28874 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #28874      +/-   ##
============================================
+ Coverage     60.88%   60.89%   +0.01%     
- Complexity    18567    18695     +128     
============================================
  Files          1093     1093              
  Lines         61322    61714     +392     
============================================
+ Hits          37333    37582     +249     
- Misses        23989    24132     +143
Impacted Files Coverage Δ Complexity Δ
lib/private/User/Session.php 58.31% <0%> (-0.61%) 140% <0%> (+1%)
...b/private/AppFramework/Utility/SimpleContainer.php 100% <0%> (ø) 18% <0%> (+1%) ⬆️
lib/private/Console/Application.php 0% <0%> (ø) 19% <0%> (ø) ⬇️
core/js/config.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
core/ajax/share.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
lib/private/Server.php 82.84% <0%> (+0.14%) 129% <0%> (ø) ⬇️
lib/private/User/User.php 83.71% <0%> (+0.18%) 96% <0%> (+32%) ⬆️
lib/private/Share/MailNotifications.php 91.24% <0%> (+0.65%) 29% <0%> (+14%) ⬆️
lib/private/Log.php 78.29% <0%> (+1.75%) 40% <0%> (+4%) ⬆️
lib/private/Installer.php 61.42% <0%> (+5.72%) 163% <0%> (+76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ac502b...14144fa. Read the comment docs.

@PVince81
Copy link
Contributor Author

@DeepDiver1975 updated and added missing tests. Please rereview

@PVince81
Copy link
Contributor Author

PVince81 commented Feb 7, 2018

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

@PVince81
Copy link
Contributor Author

as discussed with @DeepDiver1975, this goes only to master

@DeepDiver1975 DeepDiver1975 merged commit d5be225 into master Feb 13, 2018
@DeepDiver1975 DeepDiver1975 deleted the filelist-upload-usenewdav branch February 13, 2018 05:24
@PVince81
Copy link
Contributor Author

considering that we want to focus work on stable10 we might still want to backport this. adding label as reminder

@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants