Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make UI tests delete feature more readable #28825

Merged
merged 1 commit into from
Aug 29, 2017

Conversation

individual-it
Copy link
Member

Description

as discussed here #28811 (review) this PR makes the delete tests more readable and moves the single steps into PHP

When I delete the elements does check itself if the elements are disappearing from the WebUI.
Plus there is an extra step to make sure the elemens do not come back after a page reload.

I suggest to leave the Delete a file with problematic characters Scenario as it is because of the complicated way we need to combine the single parts of that file name

Motivation and Context

make better readable test

How Has This Been Tested?

run UI tests locally, travis will test more

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@phil-davis
Copy link
Contributor

Hmmm, does this go too far? (combining the initial delete of all the files with the "real time" check that the JS has removed them from being listed)
The gherkin does look very compact!
@SergioBertolinSG @davitol your opinions?

@davitol
Copy link
Contributor

davitol commented Aug 29, 2017

The gherkin does look very compact!

It looks too compact to me too but I think it is fine for merging.

@individual-it
Copy link
Member Author

ideas for alternative step descriptions?

@SergioBertolinSG
Copy link
Contributor

I find it right.

Just a bit nitpicking, I would use more indentation on the table and just one space before and after like:
| filename |

@phil-davis
Copy link
Contributor

I would have made it read:

When I delete the elements
Then the deleted elements should not be listed
And the deleted elements should not be listed after a page reload

that way the reader can understand that there is an action (deleting) followed by 2 checks.
At the moment the first check is hidden inside "When I delete the elements"

But I can cope the way it is also.

@individual-it
Copy link
Member Author

@phil-davis easy enough to implement.
@davitol @phil-davis @SergioBertolinSG please review again

@individual-it individual-it force-pushed the ui-tests-delete-more-readable branch from c46ecc7 to 62bd239 Compare August 29, 2017 09:10
@PVince81 PVince81 merged commit 900736c into master Aug 29, 2017
@PVince81 PVince81 deleted the ui-tests-delete-more-readable branch August 29, 2017 13:21
@phil-davis
Copy link
Contributor

phil-davis commented Aug 29, 2017

Backport stable10 #28838

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants