-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make UI tests delete feature more readable #28825
Conversation
Hmmm, does this go too far? (combining the initial delete of all the files with the "real time" check that the JS has removed them from being listed) |
It looks too compact to me too but I think it is fine for merging. |
ideas for alternative step descriptions? |
I find it right. Just a bit nitpicking, I would use more indentation on the table and just one space before and after like: |
I would have made it read:
that way the reader can understand that there is an action (deleting) followed by 2 checks. But I can cope the way it is also. |
6147127
to
c46ecc7
Compare
@phil-davis easy enough to implement. |
c46ecc7
to
62bd239
Compare
Backport stable10 #28838 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
as discussed here #28811 (review) this PR makes the delete tests more readable and moves the single steps into PHP
When I delete the elements
does check itself if the elements are disappearing from the WebUI.Plus there is an extra step to make sure the elemens do not come back after a page reload.
I suggest to leave the
Delete a file with problematic characters
Scenario as it is because of the complicated way we need to combine the single parts of that file nameMotivation and Context
make better readable test
How Has This Been Tested?
run UI tests locally, travis will test more
Types of changes
Checklist: