UI tests for delete feature #28809
UI tests for delete feature #28809
Conversation
| @@ -167,7 +168,7 @@ public function findRenameInputField() { | |||
| */ | |||
| public function rename($toName) { | |||
| $actionMenu = $this->openFileActionsMenu(); | |||
| $actionMenu->rename($this->fileRenameInputXpath); | |||
| $actionMenu->rename(); | |||
There was a problem hiding this comment.
nothing to do with deleting. just too much waiting that I've noticed.
| * | ||
| * @return string | ||
| */ | ||
| public function getTooltip() { |
There was a problem hiding this comment.
placed the function higher up, to make the order more logical.
| @@ -136,6 +137,7 @@ public function findFileRowByName($name, Session $session) | |||
| { | |||
| $previousFileCount = 0; | |||
| $currentFileCount = null; | |||
| $this->scrollToPosition('#' . $this->appContentId, 0, $session); | |||
There was a problem hiding this comment.
not specific to deleting but when trying to find a file at the top of the page after the page got scrolled down it would find the file but could not click it as it was out of view
| @@ -76,7 +76,8 @@ public function rename( | |||
| * @return void | |||
| */ | |||
| public function delete() { | |||
| ; | |||
| $renameBtn = $this->findButton($this->deleteActionLabel); | |||
There was a problem hiding this comment.
var name is misleading.
There was a problem hiding this comment.
copy and paste mistake 🤦♂️
| } | ||
|
|
||
| /** | ||
| * @When I mark these files for batch action |
There was a problem hiding this comment.
This step marks for batch action, and also actually does the batch delete.
Maybe the step text could be like:
When I batch delete these files:
and that would read more clearly in the scenario.
There was a problem hiding this comment.
Hmm - maybe do not put the ":" at the end - that will make it think there is a PyString coming.
There was a problem hiding this comment.
I've made now two steps out of it, that was the way I've planed it in the first place
14b0ca0 to
c327608
Compare
|
Backport stable10 #28811 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
UI test for deleting files and folder
Related Issue
owncloud/QA#437
Motivation and Context
reduce manual test time by running the smoke test automatically
How Has This Been Tested?
run tests locally and in travis
Types of changes
Checklist: