-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only reload file list when switching navigation sections #28804
Conversation
👍 |
Fixes the "flashing load" of the home folder, before then displaying the sub-folder content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving because it works. Would be another fix of an annoying little thing that can be got into the next beta maybe.
stable10: #28843 |
yay nice. I was annoyed this breaks the scrollTo private linkls.. hope this fixes it |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Reverts a previous bad fix from #27703 which causes a double reload and even breaks sometimes when opening a private link by reloading the wrong list.
Adds a better fix that only reloads a file list whenever the active navigation section has changed, because that's when we need to refresh, for example after restoring a file from trash, the "All files" list needs to refresh to display the restored folder.
Also prevents initial double reload of the file list.
Related Issue
Fixes #27890
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: