Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only reload file list when switching navigation sections #28804

Merged
merged 2 commits into from
Aug 29, 2017

Conversation

PVince81
Copy link
Contributor

Description

Reverts a previous bad fix from #27703 which causes a double reload and even breaks sometimes when opening a private link by reloading the wrong list.

Adds a better fix that only reloads a file list whenever the active navigation section has changed, because that's when we need to refresh, for example after restoring a file from trash, the "All files" list needs to refresh to display the restored folder.

Also prevents initial double reload of the file list.

Related Issue

Fixes #27890

Motivation and Context

How Has This Been Tested?

  • create folder "test" in "All files", delete it. go to trash: folder appears
  • create folder "test/sub" in "All files". Refresh page several times: folder contents is still correct, no blinking. (before this fix it was either blinking or showing the wrong contents)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@davitol
Copy link
Contributor

davitol commented Aug 29, 2017

👍

@phil-davis
Copy link
Contributor

Fixes the "flashing load" of the home folder, before then displaying the sub-folder content.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because it works. Would be another fix of an annoying little thing that can be got into the next beta maybe.

@PVince81
Copy link
Contributor Author

stable10: #28843

@guruz
Copy link
Contributor

guruz commented Sep 6, 2017

yay nice. I was annoyed this breaks the scrollTo private linkls.. hope this fixes it

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File list loaded twice
5 participants