Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added better description #28787

Merged
merged 2 commits into from
Aug 29, 2017
Merged

added better description #28787

merged 2 commits into from
Aug 29, 2017

Conversation

dercorn
Copy link
Contributor

@dercorn dercorn commented Aug 24, 2017

I added a more verbose description to this command.

@dercorn dercorn self-assigned this Aug 24, 2017
@dercorn dercorn requested review from butonic and tomneedham August 24, 2017 10:01
@@ -61,7 +61,7 @@ protected function configure() {

$this
->setName('files:scan')
->setDescription('rescan filesystem')
->setDescription('Scans the filesystem for new files and updates the file cache accordingly.')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually it's not only new files but also changed and deleted files and folders ....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And 'update file cache might be a bit too technical' ... but I have no better idea right now ..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "Scans the filesystem for changes and updates the file cache accordingly."?
"file cache" should stay imo, since that is just our terminology.

@dercorn
Copy link
Contributor Author

dercorn commented Aug 28, 2017

@DeepDiver1975 I changed the text a little. Is it okay for you now?

@dercorn dercorn dismissed DeepDiver1975’s stale review August 29, 2017 08:23

Request fulfilled and requester is on vacation.

@dercorn
Copy link
Contributor Author

dercorn commented Aug 29, 2017

@tomneedham can you give Travis another nudge?

@PVince81 PVince81 merged commit d198fbb into master Aug 29, 2017
@PVince81 PVince81 deleted the dercorn-patch-2 branch August 29, 2017 08:29
@PVince81
Copy link
Contributor

@dercorn please backport to stable10

@PVince81 PVince81 added this to the development milestone Aug 29, 2017
@DeepDiver1975
Copy link
Member

already in stable10 - 7bfb5c9

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants